Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple models from evaluate package #516

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Nov 27, 2023

PR Type

Other (refactor).

Short Description

Decouple models and evaluate package. The effect is that the evaluate methods now expect model predictions to be in the input dataset. The option to generate model predictions within the evaluate methods is removed.

Tests Added

None.

@fcogidi fcogidi added the refactor Refactor existing code, with same or similar functionality label Nov 27, 2023
@fcogidi fcogidi self-assigned this Nov 27, 2023
Copy link
Member

@amrit110 amrit110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i can fix the notebooks!

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #516 (ef77733) into main (6eb4e9c) will increase coverage by 0.24%.
The diff coverage is 19.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   64.21%   64.45%   +0.24%     
==========================================
  Files          94       94              
  Lines        9303     9265      -38     
==========================================
- Hits         5974     5972       -2     
+ Misses       3329     3293      -36     
Files Coverage Δ
cyclops/evaluate/fairness/evaluator.py 13.38% <100.00%> (+0.25%) ⬆️
cyclops/tasks/classification.py 31.94% <ø> (ø)
cyclops/data/utils.py 40.00% <0.00%> (+3.38%) ⬆️
cyclops/evaluate/utils.py 18.18% <16.66%> (-0.57%) ⬇️
cyclops/evaluate/evaluator.py 20.87% <20.00%> (+3.13%) ⬆️

Impacted file tree graph

@amrit110 amrit110 merged commit 03f6c5c into main Nov 28, 2023
7 of 8 checks passed
@amrit110 amrit110 deleted the decouple_evaluate_and_models branch November 28, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants