Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report missing slices #518

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix report missing slices #518

merged 3 commits into from
Nov 28, 2023

Conversation

a-kore
Copy link
Collaborator

@a-kore a-kore commented Nov 28, 2023

Fix

Short Description

  • Fix handling of missing metrics between periodic report generations.

Tests Added

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #518 (4788bb3) into main (03f6c5c) will decrease coverage by 0.10%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   64.45%   64.36%   -0.10%     
==========================================
  Files          94       94              
  Lines        9265     9282      +17     
==========================================
+ Hits         5972     5974       +2     
- Misses       3293     3308      +15     
Files Coverage Δ
cyclops/report/utils.py 72.52% <16.66%> (-3.49%) ⬇️

Impacted file tree graph

@a-kore a-kore merged commit 81fc151 into main Nov 28, 2023
6 of 8 checks passed
@a-kore a-kore deleted the fix-report-missing-slices branch November 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants