Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to docs deploy poetry install, update contrib md #557

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Feb 19, 2024

PR Type ([Feature | Fix | Documentation | Test])

Documentation, CI

Short Description

  • Small fix to documentation deploy workflow, where the docs dependencies weren't forced to be installed. It didn't fail because it re-used the virtual env from the build workflow (maybe future idea is to separate the build and deploy virtual envs)
  • Update contributing.md to latest info, same as documentation RST file (https://vectorinstitute.github.io/cyclops/api/contributing.html)

Tests Added

...

@amrit110 amrit110 self-assigned this Feb 19, 2024
@amrit110 amrit110 added documentation Improvements or additions to documentation ci Changes to github actions labels Feb 19, 2024
@amrit110 amrit110 requested a review from hoxell February 19, 2024 18:52
CONTRIBUTING.md Outdated Show resolved Hide resolved
@amrit110 amrit110 merged commit 087e6f8 into main Feb 19, 2024
4 checks passed
@amrit110 amrit110 deleted the fix_docs_deploy_update_contrib branch February 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to github actions documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants