Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve intersectional slicing #606

Merged
merged 1 commit into from
May 7, 2024
Merged

Improve intersectional slicing #606

merged 1 commit into from
May 7, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented May 7, 2024 •
edited

PR Type

Feature.

Short Description

  • Add option to specify slices to intersect in SliceSpec class.

Tests Added

Updated tests/cyclops/data/test_slicer.py

@fcogidi fcogidi added enhancement New feature or request refactor Refactor existing code, with same or similar functionality labels May 7, 2024
@fcogidi fcogidi requested a review from amrit110 May 7, 2024 19:08
@fcogidi fcogidi self-assigned this May 7, 2024
amrit110
amrit110 approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@amrit110 amrit110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Awesome addition.

@fcogidi fcogidi merged commit 461d036 into main May 7, 2024
8 checks passed
@fcogidi fcogidi deleted the improve_intersectional_slicing branch May 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrit110 amrit110 amrit110 approved these changes

Assignees

@fcogidi fcogidi

Labels
enhancement New feature or request refactor Refactor existing code, with same or similar functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcogidi @amrit110