Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SliceSpec and evaluator #619

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix SliceSpec and evaluator #619

merged 2 commits into from
May 16, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented May 15, 2024

PR Type

Fix.

Short Description

  • Remove duplicate slice specs after creating intersectional slices
  • Add array_lib argument to evaluate_fairness method that is called from the evaluate method.
  • Clear the defaults dictionary in metric classes so that a metric can be used with a different array type after reset is called.

Tests Added

...

@fcogidi fcogidi added bug Something isn't working refactor Refactor existing code, with same or similar functionality labels May 15, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.26%. Comparing base (d781e3d) to head (c7e9d13).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   75.24%   75.26%   +0.02%     
==========================================
  Files         128      128              
  Lines       11459    11470      +11     
==========================================
+ Hits         8622     8633      +11     
  Misses       2837     2837              
Files Coverage Δ
cyclops/data/slicer.py 88.56% <100.00%> (+0.43%) ⬆️
cyclops/evaluate/fairness/evaluator.py 13.02% <ø> (ø)
cyclops/evaluate/metrics/experimental/metric.py 88.69% <100.00%> (+0.03%) ⬆️
...clops/evaluate/metrics/experimental/metric_dict.py 92.13% <100.00%> (ø)
cyclops/evaluate/evaluator.py 22.58% <0.00%> (ø)

Impacted file tree graph

@fcogidi fcogidi merged commit ca6a26b into main May 16, 2024
11 checks passed
@fcogidi fcogidi deleted the fix_evaluators_and_slicespec branch May 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant