Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adorn_percentages("col") (per our conversation today) #51

Open
rhinopotamus opened this issue Oct 5, 2022 · 1 comment
Open

adorn_percentages("col") (per our conversation today) #51

rhinopotamus opened this issue Oct 5, 2022 · 1 comment

Comments

@rhinopotamus
Copy link
Contributor

So you were totally right: I took a quick ctrl-f through all the modules, and you only ever adorn column percentages, so there's no inconsistency.

Okay, so then here is maybe a suggestion. What if there's a brief little thing when we first introduce adorn_percentages("col") that says, here we are interested in column percentages for such-and-such reasons, here's how we do that, bam, okay but what if we're for some other reason in some other table interested in the row percentages, okay well adorn_percentages("row"), bam".

Alternatively: what students are ever going to do wrong is they're just going to leave the specifier off and not notice. So maybe instead, a thing says "what happens if we accidentally leave off "col" in here? oh no, that's row percentages, compare what happens when we say "row", wow yeah those are less useful here."

The reason I'm putting this in as a "suggestion" rather than making a pull request is because (a) low bandwidth today lol and (b) I'm diffident about the pedagogical value of this move. Maybe it shows them a thing to watch out for, but maybe also it just muddies the waters.

@VectorPosse
Copy link
Owner

VectorPosse commented Oct 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants