Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 WETH logs #969

Merged
merged 1 commit into from
Jun 22, 2024
Merged

🔊 WETH logs #969

merged 1 commit into from
Jun 22, 2024

Conversation

z0r0z
Copy link
Collaborator

@z0r0z z0r0z commented Jun 21, 2024

Description

Remove deposit/withdraw logs as ERC20 _mint/_burn accommodates.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized
Copy link
Owner

Hmm... should we?

@z0r0z
Copy link
Collaborator Author

z0r0z commented Jun 22, 2024

I think so. Vitalik added an extra event to all ETH transfers anyways, right.

@Vectorized
Copy link
Owner

Brillant.

@Vectorized Vectorized merged commit dd9ba6e into main Jun 22, 2024
9 checks passed
@Vectorized Vectorized deleted the weth-nit-mint-log branch June 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants