Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong warning showed to user when encrypting wallet? #1000

Closed
us77ipis opened this issue Apr 22, 2022 · 3 comments
Closed

Wrong warning showed to user when encrypting wallet? #1000

us77ipis opened this issue Apr 22, 2022 · 3 comments

Comments

@us77ipis
Copy link
Contributor

Description

If I understood correctly our recent discussion on discord, the warning that is shown to the user when encrypting a wallet If you encrypt your wallet and lose your passphrase, you will LOSE ALL OF YOUR Veil! is wrong, since you can always recover everything using the seed words that you backed up during wallet creation.

Expected behavior

No misleading warning, that might lead the user to think he is doing something wrong when encrypting his wallet.

Actual behavior

screenshot

Wallet version

Current master branch

@ohcee
Copy link
Contributor

ohcee commented Jan 12, 2023

I changed the warning so it does not seem so doom and gloom for encrypting your wallet.
issue#1000

@seanPhill
Copy link
Collaborator

Thanks! Elsewhere I am sure that users are told they can always restore their coins with the seed words, (although it can be a lot more work to do so than with a Bitcoin wallet), but it is good to fix it here. Next update I will check that we have that fixed, if you haven't already made a PR for it.

seanPhill added a commit that referenced this issue Jan 13, 2023
@seanPhill
Copy link
Collaborator

Done. :) Just hope that everyone does not lose their passphrase, as well as does not lose their seed phrase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants