Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Show PoW type for coinbase transactions in transactions history #1004

Merged
merged 2 commits into from
Jun 25, 2022
Merged

[GUI] Show PoW type for coinbase transactions in transactions history #1004

merged 2 commits into from
Jun 25, 2022

Conversation

us77ipis
Copy link
Contributor

@us77ipis us77ipis commented Jun 6, 2022 •
edited
Loading

  • Show the PoW type for each coinbase transaction in the transaction history
    Screenshot from 2022-06-06 15-46-53
  • Also implement filtering the transaction history by PoW type

@us77ipis
Copy link
Contributor Author

us77ipis commented Jun 6, 2022

Implemented also filtering the transaction history by PoW type.

@us77ipis us77ipis force-pushed the pow-type-transaction-history branch from 119da45 to a626ac2 Compare June 9, 2022 10:12
@us77ipis us77ipis force-pushed the pow-type-transaction-history branch from a626ac2 to 6ad4c7e Compare June 9, 2022 10:48
@us77ipis us77ipis changed the title Show PoW type for coinbase transactions in transactions history [GUI] Show PoW type for coinbase transactions in transactions history Jun 9, 2022
@seanPhill
Copy link
Collaborator

seanPhill commented Jun 9, 2022 •
edited
Loading

On wallet start up, already containing transactions, but not thousands, as it was only created in the past day, the transactions list in the Overview page is blank. There is no message indicating that the wallet might be recalculating the transactions list, if it will. I'll leave this wallet running for a few hours, but I'll have to focus on some more urgent PRs now, as these ones missed the release that got released today.

I have received (testnet) stakes since I started up, but they're still not showing up yet, and I have Show Orphans turned on in the settings.

@us77ipis
Copy link
Contributor Author

us77ipis commented Jun 9, 2022

Did you download the latest build? The (sometimes) empty transaction list problem should be fixed with the latest push from this morning.

@seanPhill
Copy link
Collaborator

I downloaded this last night. I'll check Github Actions again.

@seanPhill
Copy link
Collaborator

Great! Thanks! That saved me time getting the latest one, and as this is a new wallet I still have enough of a scrollbar handle that I can still (just) grab it, and scroll back to yesterday, when I did some mining.

RandomX blocks shown yesterday. I'll mine some SHA256D, but I can't mine ProgPow for testing.

@seanPhill
Copy link
Collaborator

Nice! :)
Screen Shot 2022-06-09 at 1 02 24 pm

@us77ipis
Copy link
Contributor Author

us77ipis commented Jun 9, 2022

But that screenshot is still not using the latest build, right? It should show "Basecoin mined (...) on <address>" 🤔

@seanPhill
Copy link
Collaborator

Screenshots from a Windows PC mining ProgPow and RandomX. :)
Screenshot_20220609-145903_TeamViewer
Screenshot_20220609-145910_TeamViewer

@seanPhill seanPhill added QA: Passed This has passed QA testing and can be merged to master Tag: Waiting For Code Review Waiting for code review from a core developer labels Jun 9, 2022
@chainsoaker chainsoaker mentioned this pull request Jun 10, 2022
Merged
@Zannick Zannick requested review from Zannick and WetOne June 18, 2022 17:38
Zannick
Zannick approved these changes Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@Zannick Zannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6ad4c7e

@Zannick Zannick added Component: GUI Primarily related to the display of the user interface Tag: TransactionRecords The display of transaction information labels Jun 18, 2022
seanPhill
seanPhill reviewed Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@seanPhill seanPhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks good as it also tested well. I'll give it a little more time for other eyes, and for community members with coding experience to get involved.

@seanPhill seanPhill added Code Review: Passed and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Jun 25, 2022
@seanPhill seanPhill merged commit 470358d into Veil-Project:master Jun 25, 2022
@WetOne
Copy link
Collaborator

WetOne commented Jun 26, 2022

utACK 6ad4c7e

@us77ipis us77ipis deleted the pow-type-transaction-history branch June 28, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanPhill seanPhill seanPhill left review comments

@Zannick Zannick Zannick approved these changes

@WetOne WetOne Awaiting requested review from WetOne

Assignees

@us77ipis us77ipis

Labels
Code Review: Passed Component: GUI Primarily related to the display of the user interface QA: Passed This has passed QA testing and can be merged to master Tag: TransactionRecords The display of transaction information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@us77ipis @seanPhill @WetOne @Zannick