Bugfix: race condition of two threads using same RandomX VM #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zannick
approved these changes
Nov 5, 2022
Zannick
approved these changes
Nov 11, 2022
seanPhill
added
the
QA: Pending
seanPhill
added
QA: In Progress
|
I have been running this for some weeks, but haven't done a lot of RandomX mining. |
seanPhill
added
QA: Passed
|
I ran this on testnet and mined a lot of RandomX without any problems. Debug log entries look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition between
veil/src/pow.cpp
Line 462 in 4107c99
veil/src/chain.cpp
Line 304 in 4107c99
which use the same RandomX VM but the first one correctly acquires the lock
cs_randomx_validatorbefore, while the second doesn't acquire the lock.This bug caused the daemon / wallet to randomly crash.