Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Fix veil.tools hyperlink in wallet #1034

Merged
merged 1 commit into from
Jun 1, 2023
Merged

[GUI] Fix veil.tools hyperlink in wallet #1034

merged 1 commit into from
Jun 1, 2023

Conversation

Necrosys
Copy link
Contributor

@Necrosys Necrosys commented Jun 1, 2023

To open a URL in a browser, setOpenExternalLinks for label_3 must set to true.

ohcee
ohcee reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@ohcee ohcee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK Although needs to be tested after the workflow gets approved

@seanPhill
Copy link
Collaborator

Approved the workflow. Let's see! :)

@ohcee
Copy link
Contributor

ohcee commented Jun 1, 2023

ACK works well for me on MacOS.

seanPhill
seanPhill approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@seanPhill seanPhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in macOS and Ubuntu.

@seanPhill seanPhill merged commit ab9c6f5 into Veil-Project:master Jun 1, 2023
7 checks passed
@seanPhill
Copy link
Collaborator

Thanks! :)

@Necrosys Necrosys deleted the fix_issue_1032 branch June 2, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohcee ohcee ohcee left review comments

@seanPhill seanPhill seanPhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Necrosys @seanPhill @ohcee