[Wallet][Qt] Fix premature Zerocoin spending in GUI #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presstab
changed the title
…erocoin in the GUI until after the user clicks the send button.
APosselli
force-pushed
the
fix_premature_zerocoin_spend
branch
from
ceb7155
to
a1044ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #272.
I split the ZerocoinSpend into preparation and commit steps. We now prepare the ZerocoinSpend when we first click "Send" in the GUI (just as we were doing with other types of transactions), and we won't commit the ZerocoinSpend until the "Send" button in the confirmation popup is clicked. Previously, these two steps were not separated and were both performed as soon as the first "Send" button was pressed (before the user confirmed sending the zerocoin).