-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: remove boost from ThreadImport. #780
init: remove boost from ThreadImport. #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine; but please maintain the bool type on LoadExternalBlockFile for future cleanup
Travis early failed due to caching I believe.. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 3660e40
assuming the other reviewer's comments to corrected.
Addressed the issues, ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f2bbec8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK f2bbec8
ACK
|
Problem
This is a refactor fix. We want to remove boost functions slowly.
Root Cause
Solution
We can work around the boost interruption point by just returning, and shutting down the program, instead. It is much cleaner than relying on boost to redirect control flow.
Unit Testing Results
Can be tested by calling -reindex or -loadblock and then pressing CTRL+C.
Should print something like: