[PoW][RandomX] Display Hashspeed after processing #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RandomX Hashspeed was not being displayed in the logfile when using blockcreation debugging
Root Cause
Technically it does; however only when you actually win a block or you get through the full 100,000 hashes without another block coming in. The problem was, if you stopped computing because another block came in while you were computing, it would restart the hashing on the next block, before it reports the hash speed used.
Solution
Move the hash debugging to before the check if the block was already found or not. Also a couple other tweaks made; reduce the cs_nonce critical section to minimum needed, as well as remove the hardcoded inner loop count, as that inner loop count is also used for nonce spacing. That way if the inner loop count is changed, the nonce separation between threads is consistent and doesn't leave gaps.
Issue
Addresses Issue #866