[PoW][RandomX] Cherry picked fixes from offical randomx repo - Part 2 #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofalltrades
added
Tag: PoW
CaveSpectre11
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
ACK 6cb9858
for the record NIT. Not sure why there was so many changes that corrected indenting; and then src/crypto/randomx/randomx.cpp jacked the indenting on most of the changed lines.
CaveSpectre11
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Keep randomx code current
Solution
Cherry picked fixes from offical randomx repo
Add a missing function to calculate a batch of hashes - tevador/RandomX@01381cc
Fix symbol collisions with blake2b - tevador/RandomX@7567cef
Fixes for cmake build with visual studio - tevador/RandomX@01914b4
Optimized Argon2 (SSSE3/AVX2) - tevador/RandomX@900a936
Fix function names for clang on Apple - tevador/RandomX@e43267f
virtual_memory: add MAP_JIT on macOS - tevador/RandomX@7c172f7
Fix compilation and JIT support on NetBSD - tevador/RandomX@708a4e5
fix potential use-after-free when reallocating cache - tevador/RandomX@32ab5de
fix test 92 not failing properly on GCC/amd64 - tevador/RandomX@148b923
Preserve floating point state when calling randomx_calculate_hash - tevador/RandomX@6a764e9
Add a missing function to calculate a batch of hashes - tevador/RandomX@01381cc
Unit Testing Results
Start the wallet
Start mining randomx
Verify you can spend mined coins