-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Move menu to cursor location instead of far right of the rectangle #906
[GUI] Move menu to cursor location instead of far right of the rectangle #906
Conversation
I did another test and although the selection window moves to the cursor, it doesn't want to stay open long enough to move the cursor to one of the selections....will need to revisit Update: Seems like the window closes too quickly for no reason. |
The timeout really has no effect on my system because the click action immediately activates the mouse enter event, but still good to include. The original singleshot timer approach didn't reset the timer each time you click. It will always hide the widget after 3.5 seconds. This approach will always reset the timer even though the mouse over event disables the timer and is triggered immediately on click. |
315c501
to
22829f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure the timer is working; but I like the behavior I'm seeing.
ACK 22829f3
The timer is basically a "just in case" the mouse isn't somehow over it on click now that the mouse enter event immediately occurs which also stops the timeout timer. |
e8f12f1
to
343482e
Compare
Ready for code review and QA? |
If one has enough address to fill the screen, clicking the bottom address cuts the menu at the bottom of the screen (I only see "copy" not "copy" and "edit"). After, my window scrolls so that the clicked address is no longer the bottom (but is still highlighted). |
Would you happen to have a screenshot of the issue for better understanding? |
Nice catch @WetOne . I've seen in the past with other applications that when there's not enough room to bring up the menu where it normally brings it up, it basically flips the anchor point. E.g. With the menu coming up with the pointer to the top left, if it was too close to the right side, it would make the anchor point top right, too close to the bottom, anchor bottom left. Too close to the bottom right corner, anchor bottom right. |
Let me see if I can copy that behavior. Good suggestions both. |
-Adjustment for timeout and enter and leave mouse event -remove commented out code this took way too long fix for off-screen dropdown
343482e
to
51bd07e
Compare
@WetOne fix applied. Please retest when you get a chance. Thank you |
ack 51bd07e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 51bd07e
Before:
After:
Previous code moved the selection menu to the far top right of the screen.
Instead, the selection menu should intuitively be right next to where you click.