-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Staking][GUI] Unlock wallet for staking dialogue on click #924
[Staking][GUI] Unlock wallet for staking dialogue on click #924
Conversation
ack b8294ee |
What is supposed to do? I clicked placed, the wallet seems for function the same. |
Clicking the toggle bottom left of screen will also open the unlock wallet password dialog as shown in the screenshot where as previously it would only show the notification that you should unlock wallet for staking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b8294ee
UnlockPasswordDialog *dialog = new UnlockPasswordDialog(/*fUnlockForStakingOnly*/true, this->walletModel, mainWindow); | ||
if(openDialogWithOpaqueBackground(dialog, mainWindow, 4)){ | ||
openToastDialog("Wallet unlocked for staking", mainWindow); | ||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Follow consistent spacing to rest of the module (space between code and brackets
if () {
} else {
etc...
Related to pull request: #913 (and mentioned there as well. This is the separated pull request)
#913 (comment)