[Trivial] Add config include for building DEBUG_LOCKCONTENTION #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/veil-config.h includes `HAVE_THREAD_LOCAL`, without which `DEBUG_LOCKCONTENTION` will fail to build due to the `static_assert`. This allows building with `./configure CPPFLAGS="-DDEBUG_LOCKCONTENTION"` without manually adding `-DHAVE_THREAD_LOCAL`.
|
This might work. I'll need to dig up the weirdness that happened with OSX when I made the option available. |
CaveSpectre11
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
utACK f86a618
I was confusing a couple different issues; the issue I'm thinking of was in the debug logging on MAC, the issue I had with DEBUG_LOCKCONTENTION is it sometimes flags things as potential deadlocks that aren't; which is why I stopped running with it on except when I was specifically looking for something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config/veil-config.h includes
HAVE_THREAD_LOCAL, without whichDEBUG_LOCKCONTENTIONwill fail to build due to thestatic_assert.This allows building with
./configure CPPFLAGS="-DDEBUG_LOCKCONTENTION"without manually adding-DHAVE_THREAD_LOCAL(when thread_local exists, of course).Tested
Built via
./configure --with-incompatible-bdb CPPFLAGS="-DDEBUG_LOCKCONTENTION"on Fedora,CONFIG_SITE=$PWD/depends/x64_64-w64-mingw32/share/config.site ./configure --prefix=/ CPPFLAGS="-DDEBUG_LOCKCONTENTION"on WSL Ubuntu 20.04