Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC][Trivial] Tweak exportzerocoins example to be sensible #939

Merged
merged 1 commit into from
May 3, 2021

Conversation

CaveSpectre11
Copy link
Collaborator

Problem

exportzerocoins help gives an example with a denomination of 5; which doesn't make any sense.

Examples:
> veil-cli exportzerocoins false 5
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "exportzerocoins", "params": [false 5] }' -H 'content-type: text/plain;' http://127.0.0.1:58812/

Solution

Tweak it to show an example of 10

Examples:
> veil-cli exportzerocoins false 10
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "exportzerocoins", "params": [false 10] }' -H 'content-type: text/plain;' http://127.0.0.1:58812/

@CaveSpectre11 CaveSpectre11 added Coin Type: Zerocoin Specifically related to zerocoin Component: RPC Related to the console commands themselves. Tag: Waiting For Code Review Waiting for code review from a core developer labels May 2, 2021
@CaveSpectre11 CaveSpectre11 self-assigned this May 2, 2021
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3cf9ddf

@codeofalltrades codeofalltrades merged commit f5e7670 into Veil-Project:master May 3, 2021
@CaveSpectre11 CaveSpectre11 added Code Review: Passed Dev Status: Merged Issue is completely finished. and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review: Passed Coin Type: Zerocoin Specifically related to zerocoin Component: RPC Related to the console commands themselves. Dev Status: Merged Issue is completely finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants