Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RG dependency #48

Closed
jonschwenk opened this issue Aug 10, 2021 · 1 comment · Fixed by #49
Closed

Remove RG dependency #48

jonschwenk opened this issue Aug 10, 2021 · 1 comment · Fixed by #49

Comments

@jonschwenk
Copy link
Collaborator

Involves copying rivgraph.im_utils.regionprops() and .crop_binary_coords(). The OpenCV dependence might be removable if https://scikit-image.org/docs/dev/api/skimage.measure.html#skimage.measure.find_contours provides the exact functionality of OpenCV's findContours. However, this is a heavily-used operation so lots of testing would need to be done to ensure that it's a 1:1 swap. No need to remove OpenCV, just throwing that bit in.

@tzussman
Copy link
Collaborator

Making new issue for OpenCB dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants