Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default resource limits to be specified in the artifact definition #1011

Closed
scudette opened this issue Apr 7, 2021 · 15 comments
Closed

Comments

@scudette
Copy link
Contributor

scudette commented Apr 7, 2021

Currently resource limits are hard coded but some artifact need longer time or more uploaded bytes. By having these in the artifact definition we can tailor those limits to the right artifacts.

@predictiple
Copy link
Contributor

The timeout value doesn't seem to be applied

dex_offline yaml - dex-artifacts - Visual Studio Code_802

result
Velociraptor Response and Monitoring - Brave_801

Also it would be nice if the "New Collection: Specify Resources" screen showed the values if specified, but I guess that might be tricky if multiple artifacts are selected?

@scudette
Copy link
Contributor Author

Timeout is actually applied for each query (i.e. artifact + source) in a collection.

The GUI probably needs to show something else here (probably "default" rather than 600).

When specifying the timeout in the resources tab then it overrides the timeout in the artifact definition. But if you don't specify then it will be taken as the artifact default, or if there is no default then 600.

You should be able to see the correct timeout set in the request tab.

@predictiple
Copy link
Contributor

Ah thanks, yes it does show the correct timeout value in the Requests tab.

@predictiple
Copy link
Contributor

predictiple commented Apr 15, 2021

The resources settings don't seem to apply at all when used in a server artifact.

the artifact definition specifies:

resources:
  timeout: 666666
  max_rows: 999999999
  max_upload_bytes: 99999999999

Incidentally on the New Collection tab the timeout value is shown but not the others:

Screenshot from 2021-04-15 14-22-14

Running the collection, the Requests tab shows:

"max_row": "1000",
"timeout": "666666"

and the collection times out after 600 seconds:
Screenshot from 2021-04-15 14-31-32

It would be handy if the resources settings were applied because my use case is taking a (typically large) collection and forwarding it to Elastic on-demand. The server artifact is a simple one and very similar to Elastic.Flows.Upload

@predictiple
Copy link
Contributor

forgot to mention, the above testing is with
version: 0.5.8-rc1
commit: cf9311b

@predictiple
Copy link
Contributor

It seems like the timeout value is ignored for server artifacts, even if entered manually on the Specify Resources tab. Even though the Requests tab shows the correct timeout value, the collection always times out at 600 seconds.

@predictiple
Copy link
Contributor

Testing with a trivial long-running server artifact confirms that the 600sec timeout is hardcoded. Neither the resources setting in the artifact, nor the Specify Resources tab overrides the timeout (which makes one wonder why that page even displays a Max Execution Time setting).

That means post-processing tasks longer than 10 minutes are impossible.

@scudette
Copy link
Contributor Author

Yes that is correct, as can be seen here

timeout: time.Second * time.Duration(600),

The timeout is fixed.

@predictiple
Copy link
Contributor

Is this likely to change?

It doesn't seem improbable that post-processing tasks could take longer than client collection tasks, especially given that the client collection timeout can be arbitrarily long.

@scudette
Copy link
Contributor Author

Yes - this is clearly an oversight :-). Let's open another issue for it.

@scudette
Copy link
Contributor Author

Should be fixed by #1020

@predictiple
Copy link
Contributor

Thanks for attending to this so quickly. I really appreciate it. I've tested successfully with the new build.

One thing that's interesting is that the Requests tab shows a max_row of 1000 even though my artifact specifies max_rows (note the 's') of 999999999.

Screenshot from 2021-04-16 19-13-25

The collection (server artifact) didn't stop at 1000 rows though, so it does seem to be using the value defined in the artifact. Possibly there are some discrepancies with max_row vs. max_rows, or maybe max_row is another setting that has some other purpose that I'm just not aware of.

@scudette
Copy link
Contributor Author

scudette commented Apr 16, 2021 via email

@predictiple
Copy link
Contributor

I don't think there should be any limits at all, but it's working perfectly now with huge limits 🤓

With the max_row / max_rows it just seems potentially misleading if it displays a limit when there is none, and it also seems like max_row vs. max_rows is possibly an older and a newer name for the same setting that could cause trouble in future if one doesn't notice the missing 's'.

@scudette
Copy link
Contributor Author

Should be fixed in 0.5.9-rc1

scudette pushed a commit that referenced this issue Mar 19, 2023
<h3>Snyk has created this PR to upgrade moment-timezone from 0.5.40 to
0.5.41.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-02-25.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
      <li>
<b>0.5.41</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.41">2023-02-25</a></br><ul>
<li>Updated <code>moment</code> npm dependency to <code>2.29.4</code> to
remove automated warnings about insecure dependencies <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1376195089" data-permission-text="Title is private"
data-url="moment/moment-timezone#1004"
data-hovercard-type="pull_request"
data-hovercard-url="/moment/moment-timezone/pull/1004/hovercard"
href="https://snyk.io/redirect/github/moment/moment-timezone/pull/1004">#1004</a>.<br>
Moment Timezone still works with core Moment <code>2.9.0</code> and
higher.</li>
<li>Updated all dev dependencies including UglifyJS, which produces the
minified builds.</li>
<li>Added deprecation warning to the pre-built
<code>moment-timezone-with-data-2012-2022</code> bundles <a
href="https://snyk.io/redirect/github/moment/moment-timezone/issues/1035"
data-hovercard-type="issue"
data-hovercard-url="/moment/moment-timezone/issues/1035/hovercard">#1035</a>.<br>
Use the rolling <code>moment-timezone-with-data-10-year-range</code>
files instead.</li>
</ul>
      </li>
      <li>
<b>0.5.40</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.40">2022-12-11</a></br><ul>
<li>Updated data to IANA TZDB <code>2022g</code></li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases">moment-timezone
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/98d3add7187947f37046a316802dcdfe40ad306a">98d3add</a>
Build moment-timezone 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/78cf3ade7b138f1d464be79194680fc1a8a7e290">78cf3ad</a>
changelog: Add 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cd35dc6e3c806c91d46e7e6bc5039505f73052f3">cd35dc6</a>
Bump version to 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/76f5a75096026144f20c5e12adf325862e70e21c">76f5a75</a>
Re-number build tasks to match new running order</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/ace9a77b0d410509a6a8e92f21d1e4a15f8bce64">ace9a77</a>
Fix broken badges in README</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8080504d8e39739e82e99ab2a87c60de9cd8915d">8080504</a>
Bump moment dependency to 2.29.4 (#1004)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/61b14d67a4a479ae3f95892a8ae145f2b0ba9dfd">61b14d6</a>
Add deprecation warning to 2012-2022 pre-built files (#1036)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/fc2936973a0be8b8f84e856ca23ee8d17441170f">fc29369</a>
Bump remaining grunt-contrib packages</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/c83479e54083f132dfc3455ef606794e291a37fe">c83479e</a>
tests: Fix guess tests for 2023</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/e501621297d7f992325bee5641f31c28a034addf">e501621</a>
Bump y18n from 4.0.0 to 4.0.3 (#1026)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/0a7b5ddb47a59a5cc4efbc5e344e33d786955bd8">0a7b5dd</a>
Bump shelljs and grunt-contrib-jshint (#1025)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/6078ad6921490bf05bc5b9e896bee63ef786d9d0">6078ad6</a>
Bump ejs and grunt-contrib-nodeunit (#1013)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/84e665aa330c182533f72f7d4af73094a06c532f">84e665a</a>
Bump qs from 6.5.2 to 6.5.3 (#1021)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/5bdbd1143db3d54eed69d6e2d9deb2e56dfe86c9">5bdbd11</a>
Bump minimatch from 3.0.4 to 3.0.8 (#1016)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8d1a6e1e0fe2e393ccf47f853ccd321aa1fa85b0">8d1a6e1</a>
Bump minimist, mkdirp and handlebars (#1012)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cfbbd5cd03fdde4374badc662db3b42158eeced9">cfbbd5c</a>
Bump json-schema and jsprim (#1011)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/36ccdd3659490ba59cc4ba86122b535aa3c81a5d">36ccdd3</a>
Bump async from 2.6.2 to 2.6.4 (#1010)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/4b38e45977b9a8b36f7814aa3f6be93bf9fb488b">4b38e45</a>
Bump ajv from 6.10.0 to 6.12.6 (#1003)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/moment/moment-timezone/compare/d34de5593ddc0ccb7d4d73f3c7364e45cf28058a...98d3add7187947f37046a316802dcdfe40ad306a">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmMWM1MzU0Yy0yNGZkLTQwNzMtYWQzNS1lMTgzYjJmY2MwMjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImYxYzUzNTRjLTI0ZmQtNDA3My1hZDM1LWUxODNiMmZjYzAyNCJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg&#x3D;moment-timezone&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","prPublicId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","dependencies":[{"name":"moment-timezone","from":"0.5.40","to":"0.5.41"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-02-25T07:02:31.672Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
scudette pushed a commit that referenced this issue Mar 20, 2023
<h3>Snyk has created this PR to upgrade moment-timezone from 0.5.40 to
0.5.41.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-02-25.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
      <li>
<b>0.5.41</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.41">2023-02-25</a></br><ul>
<li>Updated <code>moment</code> npm dependency to <code>2.29.4</code> to
remove automated warnings about insecure dependencies <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1376195089" data-permission-text="Title is private"
data-url="moment/moment-timezone#1004"
data-hovercard-type="pull_request"
data-hovercard-url="/moment/moment-timezone/pull/1004/hovercard"
href="https://snyk.io/redirect/github/moment/moment-timezone/pull/1004">#1004</a>.<br>
Moment Timezone still works with core Moment <code>2.9.0</code> and
higher.</li>
<li>Updated all dev dependencies including UglifyJS, which produces the
minified builds.</li>
<li>Added deprecation warning to the pre-built
<code>moment-timezone-with-data-2012-2022</code> bundles <a
href="https://snyk.io/redirect/github/moment/moment-timezone/issues/1035"
data-hovercard-type="issue"
data-hovercard-url="/moment/moment-timezone/issues/1035/hovercard">#1035</a>.<br>
Use the rolling <code>moment-timezone-with-data-10-year-range</code>
files instead.</li>
</ul>
      </li>
      <li>
<b>0.5.40</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.40">2022-12-11</a></br><ul>
<li>Updated data to IANA TZDB <code>2022g</code></li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases">moment-timezone
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/98d3add7187947f37046a316802dcdfe40ad306a">98d3add</a>
Build moment-timezone 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/78cf3ade7b138f1d464be79194680fc1a8a7e290">78cf3ad</a>
changelog: Add 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cd35dc6e3c806c91d46e7e6bc5039505f73052f3">cd35dc6</a>
Bump version to 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/76f5a75096026144f20c5e12adf325862e70e21c">76f5a75</a>
Re-number build tasks to match new running order</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/ace9a77b0d410509a6a8e92f21d1e4a15f8bce64">ace9a77</a>
Fix broken badges in README</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8080504d8e39739e82e99ab2a87c60de9cd8915d">8080504</a>
Bump moment dependency to 2.29.4 (#1004)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/61b14d67a4a479ae3f95892a8ae145f2b0ba9dfd">61b14d6</a>
Add deprecation warning to 2012-2022 pre-built files (#1036)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/fc2936973a0be8b8f84e856ca23ee8d17441170f">fc29369</a>
Bump remaining grunt-contrib packages</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/c83479e54083f132dfc3455ef606794e291a37fe">c83479e</a>
tests: Fix guess tests for 2023</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/e501621297d7f992325bee5641f31c28a034addf">e501621</a>
Bump y18n from 4.0.0 to 4.0.3 (#1026)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/0a7b5ddb47a59a5cc4efbc5e344e33d786955bd8">0a7b5dd</a>
Bump shelljs and grunt-contrib-jshint (#1025)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/6078ad6921490bf05bc5b9e896bee63ef786d9d0">6078ad6</a>
Bump ejs and grunt-contrib-nodeunit (#1013)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/84e665aa330c182533f72f7d4af73094a06c532f">84e665a</a>
Bump qs from 6.5.2 to 6.5.3 (#1021)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/5bdbd1143db3d54eed69d6e2d9deb2e56dfe86c9">5bdbd11</a>
Bump minimatch from 3.0.4 to 3.0.8 (#1016)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8d1a6e1e0fe2e393ccf47f853ccd321aa1fa85b0">8d1a6e1</a>
Bump minimist, mkdirp and handlebars (#1012)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cfbbd5cd03fdde4374badc662db3b42158eeced9">cfbbd5c</a>
Bump json-schema and jsprim (#1011)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/36ccdd3659490ba59cc4ba86122b535aa3c81a5d">36ccdd3</a>
Bump async from 2.6.2 to 2.6.4 (#1010)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/4b38e45977b9a8b36f7814aa3f6be93bf9fb488b">4b38e45</a>
Bump ajv from 6.10.0 to 6.12.6 (#1003)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/moment/moment-timezone/compare/d34de5593ddc0ccb7d4d73f3c7364e45cf28058a...98d3add7187947f37046a316802dcdfe40ad306a">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmMWM1MzU0Yy0yNGZkLTQwNzMtYWQzNS1lMTgzYjJmY2MwMjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImYxYzUzNTRjLTI0ZmQtNDA3My1hZDM1LWUxODNiMmZjYzAyNCJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg&#x3D;moment-timezone&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","prPublicId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","dependencies":[{"name":"moment-timezone","from":"0.5.40","to":"0.5.41"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-02-25T07:02:31.672Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
scudette pushed a commit that referenced this issue Mar 20, 2023
<h3>Snyk has created this PR to upgrade moment-timezone from 0.5.40 to
0.5.41.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-02-25.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
      <li>
<b>0.5.41</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.41">2023-02-25</a></br><ul>
<li>Updated <code>moment</code> npm dependency to <code>2.29.4</code> to
remove automated warnings about insecure dependencies <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1376195089" data-permission-text="Title is private"
data-url="moment/moment-timezone#1004"
data-hovercard-type="pull_request"
data-hovercard-url="/moment/moment-timezone/pull/1004/hovercard"
href="https://snyk.io/redirect/github/moment/moment-timezone/pull/1004">#1004</a>.<br>
Moment Timezone still works with core Moment <code>2.9.0</code> and
higher.</li>
<li>Updated all dev dependencies including UglifyJS, which produces the
minified builds.</li>
<li>Added deprecation warning to the pre-built
<code>moment-timezone-with-data-2012-2022</code> bundles <a
href="https://snyk.io/redirect/github/moment/moment-timezone/issues/1035"
data-hovercard-type="issue"
data-hovercard-url="/moment/moment-timezone/issues/1035/hovercard">#1035</a>.<br>
Use the rolling <code>moment-timezone-with-data-10-year-range</code>
files instead.</li>
</ul>
      </li>
      <li>
<b>0.5.40</b> - <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases/tag/0.5.40">2022-12-11</a></br><ul>
<li>Updated data to IANA TZDB <code>2022g</code></li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/moment/moment-timezone/releases">moment-timezone
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>moment-timezone</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/98d3add7187947f37046a316802dcdfe40ad306a">98d3add</a>
Build moment-timezone 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/78cf3ade7b138f1d464be79194680fc1a8a7e290">78cf3ad</a>
changelog: Add 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cd35dc6e3c806c91d46e7e6bc5039505f73052f3">cd35dc6</a>
Bump version to 0.5.41</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/76f5a75096026144f20c5e12adf325862e70e21c">76f5a75</a>
Re-number build tasks to match new running order</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/ace9a77b0d410509a6a8e92f21d1e4a15f8bce64">ace9a77</a>
Fix broken badges in README</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8080504d8e39739e82e99ab2a87c60de9cd8915d">8080504</a>
Bump moment dependency to 2.29.4 (#1004)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/61b14d67a4a479ae3f95892a8ae145f2b0ba9dfd">61b14d6</a>
Add deprecation warning to 2012-2022 pre-built files (#1036)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/fc2936973a0be8b8f84e856ca23ee8d17441170f">fc29369</a>
Bump remaining grunt-contrib packages</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/c83479e54083f132dfc3455ef606794e291a37fe">c83479e</a>
tests: Fix guess tests for 2023</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/e501621297d7f992325bee5641f31c28a034addf">e501621</a>
Bump y18n from 4.0.0 to 4.0.3 (#1026)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/0a7b5ddb47a59a5cc4efbc5e344e33d786955bd8">0a7b5dd</a>
Bump shelljs and grunt-contrib-jshint (#1025)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/6078ad6921490bf05bc5b9e896bee63ef786d9d0">6078ad6</a>
Bump ejs and grunt-contrib-nodeunit (#1013)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/84e665aa330c182533f72f7d4af73094a06c532f">84e665a</a>
Bump qs from 6.5.2 to 6.5.3 (#1021)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/5bdbd1143db3d54eed69d6e2d9deb2e56dfe86c9">5bdbd11</a>
Bump minimatch from 3.0.4 to 3.0.8 (#1016)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/8d1a6e1e0fe2e393ccf47f853ccd321aa1fa85b0">8d1a6e1</a>
Bump minimist, mkdirp and handlebars (#1012)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/cfbbd5cd03fdde4374badc662db3b42158eeced9">cfbbd5c</a>
Bump json-schema and jsprim (#1011)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/36ccdd3659490ba59cc4ba86122b535aa3c81a5d">36ccdd3</a>
Bump async from 2.6.2 to 2.6.4 (#1010)</li>
<li><a
href="https://snyk.io/redirect/github/moment/moment-timezone/commit/4b38e45977b9a8b36f7814aa3f6be93bf9fb488b">4b38e45</a>
Bump ajv from 6.10.0 to 6.12.6 (#1003)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/moment/moment-timezone/compare/d34de5593ddc0ccb7d4d73f3c7364e45cf28058a...98d3add7187947f37046a316802dcdfe40ad306a">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmMWM1MzU0Yy0yNGZkLTQwNzMtYWQzNS1lMTgzYjJmY2MwMjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImYxYzUzNTRjLTI0ZmQtNDA3My1hZDM1LWUxODNiMmZjYzAyNCJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg&#x3D;moment-timezone&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","prPublicId":"f1c5354c-24fd-4073-ad35-e183b2fcc024","dependencies":[{"name":"moment-timezone","from":"0.5.40","to":"0.5.41"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-02-25T07:02:31.672Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants