Added ListActiveHunts Function to Hunt Dispatcher Interface #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scudette
reviewed
Apr 28, 2024
| @@ -106,7 +106,10 @@ type IHuntDispatcher interface { | |||
| acl_manager vql_subsystem.ACLManager, | |||
| hunt *api_proto.Hunt) (*api_proto.Hunt, error) | |||
|
|
|||
| // Deprecated - use GetHunts for paged access | |||
| ListActiveHunts(ctx context.Context, | |||
There was a problem hiding this comment.
Since this function is deprecated we probably dont want to add another function like it. We need a better approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended Hunt dispatcher interface to add a function that allows for only returning active hunts. This function will not necessarily be used in the base Velociraptor project but will allow for much more efficient hunt dispatching in the Cloudvelo layer since database queries are used when determining which hunts need to be dispatched.