Control memory use in memcache #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under high load we need to create pushback to keep the server under control: 1. When the number of cached bytes goes over the limit writes are switched to synchronous - this pushes back against the clients and keeps server memory in check. 2. Journal sync operations are now done in worker pool to avoid uncontrolled goroutine creation. When the pool is full async journal writes are converted to synchronous writes to create pushback.
scudette
added a commit
that referenced
this pull request
May 21, 2024
Under high load we need to create pushback to keep the server under control: 1. When the number of cached bytes goes over the limit writes are switched to synchronous - this pushes back against the clients and keeps server memory in check. 2. Journal sync operations are now done in worker pool to avoid uncontrolled goroutine creation. When the pool is full async journal writes are converted to synchronous writes to create pushback.
scudette
added a commit
that referenced
this pull request
May 21, 2024
Under high load we need to create pushback to keep the server under control: 1. When the number of cached bytes goes over the limit writes are switched to synchronous - this pushes back against the clients and keeps server memory in check. 2. Journal sync operations are now done in worker pool to avoid uncontrolled goroutine creation. When the pool is full async journal writes are converted to synchronous writes to create pushback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under high load we need to create pushback to keep the server under control: