Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: add entitlements needed for camera/microphone access #533

Merged
merged 1 commit into from Apr 26, 2024

Conversation

khcrysalis
Copy link
Contributor

@khcrysalis khcrysalis commented Apr 22, 2024

Problem

With Vesktop v1.5.1 there was a problem with Vesktop not requesting for permission and rather denying access immediately, I assume it is due to it no longer having an ad-hoc signature, though I don't exactly know the specifics but.... adding/specifying the entitlements manually seems to work fine.

Was pretty simple to fix, just adding the entitlements file to build/ and electron-builder will sign with those entitlements. (not sure why it doesn't use the ones provided in package.json..)

Before

image
image

After

image

image

Note

Also, assuming that it required proper entitlements when signed; camera access and access to bluetooth devices most likely didn't exactly work as well.. Though correct me if I'm wrong, I'm not gonna test it as I don't have devices neccessary.

I have also tested this on an M2 mac with a developer certificate.

@khcrysalis
Copy link
Contributor Author

khcrysalis commented Apr 22, 2024

Also when testing permissions for the microphone, you can get it to prompt back up if you've already allowed it with this command:

sqlite3 ~/Library/Application\ Support/com.apple.TCC/TCC.db
delete from access where service='kTCCServiceMicrophone' and client='dev.vencord.vesktop';

Though would not recommend you keep vencord opened when doing so because it will prompt you that it doesn't have access when it indeed does. So either kill the application before doing it or kill it after.

For screen recording it should ask for permissions and not require any new entitlements, so allowing that in settings with the prompt wouldn't need anything fixing within vencord

@Vendicated Vendicated changed the base branch from main to mac-entitlements April 26, 2024 19:37
@Vendicated Vendicated changed the title Add entitlements needed for camera/microphone access mac: add entitlements needed for camera/microphone access Apr 26, 2024
@Vendicated Vendicated merged commit 9aaa38e into Vencord:mac-entitlements Apr 26, 2024
1 check passed
TheAyes pushed a commit to TheAyes/Vesktop that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants