-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): Better Quests #2380
base: main
Are you sure you want to change the base?
Conversation
+ Added quests page instead; + Added number badge indicating how many active/new quests you have;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also get some patches to attempt to progress quests when streaming anything? It's possible, I'm doing it with a JS snippet right now
replace: "$&,$self.QuestButtonComponent()," | ||
} | ||
}, | ||
{ // Add new route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the way you're adding a route here will break something
// Routes used in this plugin (in case someone wants to add new ones) | ||
const routes = new Map<string, RouteData>(); | ||
|
||
routes.set("/questsMenu", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause a 404 on reload. If you use /channels/@quests
or something like that it will not do this
|
||
|
||
// Routes used in this plugin (in case someone wants to add new ones) | ||
const routes = new Map<string, RouteData>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a proper routes API?
path: "/questsMenu", | ||
render: (...props) => <QuestPage {...props} />, | ||
disableTrack: 1, | ||
redirectTo: "/channels/@me" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant
); | ||
}; | ||
|
||
const redirectRoute = (ev: BeforeUnloadEvent) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't foolproof
Somehow me changing default branch on my fork made my previous pull request ( #2364 ) get closed and branch "removed" even though it still exists.
Sorry guys 馃槶 For info about what this pull request introduces check out the previous pull request that got closed.