ctrlEnterSend: use cmd+enter on macOS #2502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, the ctrl key is generally used as a secondary alt key for shortcuts. The cmd (⌘) key is the "main" modifier key, the equivalent of ctrl on windows/linux.
Vendicated
reviewed
May 26, 2024
| @@ -54,7 +54,7 @@ export default definePlugin({ | |||
| result = event.shiftKey; | |||
| break; | |||
| case "ctrl+enter": | |||
| result = event.ctrlKey; | |||
| result = process.platform === "darwin" ? event.metaKey : event.ctrlKey; | |||
There was a problem hiding this comment.
we're in the browser not nodejs
Vendicated
added a commit
that referenced
this pull request
May 26, 2024
- FriendsSince: Don't show for friend requests - FakeNitro: Fix attempting to bypass unicode emojis #2503 - MessageLatency: ignore bots #2504 - CtrlEnterSend: use cmd+enter on macOS #2502 - ReplaceGoogleSearch: trim LF character #2488 Co-authored-by: AutumnVN <autumnvnchino@gmail.com> Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com> Co-authored-by: Lumap <lumap@duck.com> Co-authored-by: Mylloon <kennel.anri@tutanota.com>
|
Thanks! Pushed via c836270 |
ImLvna
pushed a commit
to ImLvna/Vencord
that referenced
this pull request
May 27, 2024
- FriendsSince: Don't show for friend requests - FakeNitro: Fix attempting to bypass unicode emojis Vendicated#2503 - MessageLatency: ignore bots Vendicated#2504 - CtrlEnterSend: use cmd+enter on macOS Vendicated#2502 - ReplaceGoogleSearch: trim LF character Vendicated#2488 Co-authored-by: AutumnVN <autumnvnchino@gmail.com> Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com> Co-authored-by: Lumap <lumap@duck.com> Co-authored-by: Mylloon <kennel.anri@tutanota.com>
LunaisLazier
pushed a commit
to LunaisLazier/Mooncord
that referenced
this pull request
Jun 6, 2024
- FriendsSince: Don't show for friend requests - FakeNitro: Fix attempting to bypass unicode emojis Vendicated#2503 - MessageLatency: ignore bots Vendicated#2504 - CtrlEnterSend: use cmd+enter on macOS Vendicated#2502 - ReplaceGoogleSearch: trim LF character Vendicated#2488 Co-authored-by: AutumnVN <autumnvnchino@gmail.com> Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com> Co-authored-by: Lumap <lumap@duck.com> Co-authored-by: Mylloon <kennel.anri@tutanota.com>
Autumnlight02
pushed a commit
to Autumnlight02/Vencord
that referenced
this pull request
Jun 19, 2024
- FriendsSince: Don't show for friend requests - FakeNitro: Fix attempting to bypass unicode emojis Vendicated#2503 - MessageLatency: ignore bots Vendicated#2504 - CtrlEnterSend: use cmd+enter on macOS Vendicated#2502 - ReplaceGoogleSearch: trim LF character Vendicated#2488 Co-authored-by: AutumnVN <autumnvnchino@gmail.com> Co-authored-by: rushiiMachine <33725716+rushiiMachine@users.noreply.github.com> Co-authored-by: Lumap <lumap@duck.com> Co-authored-by: Mylloon <kennel.anri@tutanota.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, the ctrl key is generally used as a secondary alt key for shortcuts. The cmd (⌘) key is the "main" modifier key, the equivalent of ctrl on windows/linux.