Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more generic checks for xrandr and freebsd support #2

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

l2ol33rt
Copy link
Contributor

@l2ol33rt l2ol33rt commented Mar 4, 2017

Freebsd puts the xrandr binary in /usr/local/bin/xrandr. Instead I just made the check more generic.

Appreciate the project, comes in handy for my freebsd/i3 laptop install!

Let me know if you need me to consider anything else.

~Rob

@Ventto
Copy link
Owner

Ventto commented Mar 6, 2017

Thanks for your contribution. Indeed.
Bash being the shell/hashbang, I'll consistently use hash.
In a near future, I'll turn mons into a POSIX script. So I recommand using command -v instead.

@l2ol33rt
Copy link
Contributor Author

l2ol33rt commented Mar 8, 2017

@Ventto good point! Actually didnt even realize it was using bash. Went ahead and made the change to using command -v and seems to be working as expected. Also spun out an issue to track the POSIX script migration in the future.

@l2ol33rt l2ol33rt mentioned this pull request Mar 8, 2017
@Ventto Ventto merged commit b56e0cb into Ventto:master Mar 8, 2017
@Ventto
Copy link
Owner

Ventto commented Mar 8, 2017

@l2ol33rt, thanks for changes.
I will soon stride along the POSIX way.

Ventto pushed a commit that referenced this pull request Mar 16, 2017
@Ventto Ventto changed the title Adding more generic checks for xrandr and freebsd support Add more generic checks for xrandr and freebsd support May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants