adding compatibility with laravel 5.8

[seedgabo]

using Events::dispatch instead of Events::fire to fix support with laravel 5.8

[rockfreak]

Confirmed to work

[tabacitu]

@duellsy I know the package is officially abandoned now - sad to hear but I totally understand it, I know how time-consuming it is to maintain packages. But :-)

Could you please merge & tag this one PR, so that it works on Laravel 5.8 too? This should give your users time to migrate to a different auditing package. Or you the time to find a different maintainer. Will you consider it please?

Cheers! Thanks for a great package. Sad to hear it's no longer feasible for you to maintain it.

[tabacitu]

Feel free to add me as maintainer to merge this, if you can't do it yourself. I do not intend to maintain the package, but I do intend to make it work on L5.8 so people have more time to choose alternatives.

[duellsy]

happy to merge if it can be confirmed that this will either be backwards compatible, or at least if composer.json is updated to ensure people using older versions of laravel aren't impacted

[borisson]

This can be committed as-is because the ::fire method was already an alias for ::dispatch in earlier versions of laravel (namely 5.4+).

The dispatch method was added in 5.4 and the fire method was removed, without a proper deprecation path in 5.8. There was a 2 year period in which both fire and dispatch existed but fire was just an alias.

So I think we need to update this PR to also include a change in composer.json to say that this requires laravel/framework: ~5.4

@seedgabo can you please make that change in the pull request so that @duellsy can merge this branch, allowing people using backpack to update to the latest version of laravel without too much pain.

[duellsy]

@seedgabo following up on this, if you can make the updates as above, I'm happy to merge this in, and will tag as a new release, so things don't break for existing users with older Laravel installations

[tabacitu]

Exactly. What @borisson said :-) It's been an alias since L5.4.
Sure, here you go @duellsy - check out PR #347