fix: PVE004-3

VenusProtocol · Dec 27, 2022 · b4cc242 · b4cc242
1 parent 4e9070f
commit b4cc242
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/contracts/Pool/PoolRegistry.sol b/contracts/Pool/PoolRegistry.sol
@@ -223,6 +223,11 @@ contract PoolRegistry is Ownable2StepUpgradeable {
      * @notice Add a market to an existing pool and then mint to provide initial supply
      */
     function addMarket(AddMarketInput memory input) external onlyOwner {
+        require(
+            _vTokens[input.comptroller][input.asset] == address(0),
+            "RegistryPool: Market already added for asset comptroller combination"
+        );
+
         InterestRateModel rate;
         if (input.rateModel == InterestRateModels.JumpRate) {
             rate = InterestRateModel(

diff --git a/tests/hardhat/PoolRegistry.ts b/tests/hardhat/PoolRegistry.ts
@@ -318,6 +318,15 @@ describe("PoolRegistry: Tests", function () {
       expect(await vToken.accessControlManager()).to.equal(fakeAccessControlManager.address);
     });
 
+    it("reverts if market is readded with same comptroller asset combination", async () => {
+      await mockToken.faucet(INITIAL_SUPPLY);
+      await mockToken.approve(poolRegistry.address, INITIAL_SUPPLY);
+
+      await expect(poolRegistry.addMarket(await withDefaultMarketParameters())).to.be.revertedWith(
+        "RegistryPool: Market already added for asset comptroller combination",
+      );
+    });
+
     it("sets rate model to a new JumpRateModel with the correct parameters", async () => {
       await mockToken.faucet(INITIAL_SUPPLY);
       await mockToken.approve(poolRegistry.address, INITIAL_SUPPLY);