Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symbols map for pattern character #54

Merged
merged 1 commit into from Apr 5, 2016

Conversation

gufengwyx8
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.03%) to 99.338% when pulling fa0954c on gufengwyx8:master into 0ae8ff3 on VerbalExpressions:master.

@@ -18,6 +20,19 @@
private StringBuilder suffixes = new StringBuilder();
private int modifiers = Pattern.MULTILINE;

private static final Map<Character, Integer> SYMBOL_MAP;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer initializer

 private static final Map<Character, Integer> SYMBOL_MAP = new HashMap<Character, Integer>() {{
        put(...);
        put(...);
    }} ;

which is more readable imho

@coveralls
Copy link

Coverage Status

Coverage increased (+13.03%) to 99.338% when pulling cd44fa0 on gufengwyx8:master into 0ae8ff3 on VerbalExpressions:master.

@gufengwyx8
Copy link
Contributor Author

Thank you for your advice!

@lanwen
Copy link
Contributor

lanwen commented Apr 5, 2016

thanks!

@lanwen lanwen merged commit 6cfe719 into VerbalExpressions:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants