Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performant way to using StateReader #168

Merged
merged 8 commits into from Oct 8, 2020
Merged

Performant way to using StateReader #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
55c4eff
:zap: WIP
muukii Oct 7, 2020
66d5e70
:evergreen_tree: Update
muukii Oct 7, 2020
da70864
:evergreen_tree: Update
muukii Oct 7, 2020
3391e53
Remove debugging code
muukii Oct 7, 2020
9cbb1aa
Remove typealias
muukii Oct 7, 2020
00db362
Update docs
muukii Oct 7, 2020
1f7da19
Update
muukii Oct 7, 2020
107e827
Update podspec
muukii Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cocoapods-deploy.yml
View file
Open in desktop
Expand Up @@ -20,4 +20,4 @@ jobs:
- name: Deploy
env:
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
run: pod trunk push Verge.podspec
run: pod trunk push Verge.podspec --allow-warnings
2 changes: 1 addition & 1 deletion .github/workflows/pods.yml
View file
Open in desktop
Expand Up @@ -16,4 +16,4 @@ jobs:
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: Lint Cocoapods
run: pod lib lint
run: pod lib lint --allow-warnings
152 changes: 151 additions & 1 deletion Demo/Demo.xcodeproj/project.pbxproj
View file
Open in desktop
Expand Up @@ -8,6 +8,14 @@

/* Begin PBXBuildFile section */
13BD6D0FA0ABF698AFCCA4D8 /* Pods_Demo_VergeStoreDemoSwiftUI.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 823BB27FFFB6D98FF641E929 /* Pods_Demo_VergeStoreDemoSwiftUI.framework */; };
4B19FCAD252E33A0003A628D /* StateReaderDemoApp.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4B19FCAC252E33A0003A628D /* StateReaderDemoApp.swift */; };
4B19FCAF252E33A0003A628D /* ContentView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4B19FCAE252E33A0003A628D /* ContentView.swift */; };
4B19FCB1252E33A1003A628D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 4B19FCB0252E33A1003A628D /* Assets.xcassets */; };
4B19FCB4252E33A1003A628D /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 4B19FCB3252E33A1003A628D /* Preview Assets.xcassets */; };
4B19FCC9252E33D5003A628D /* VergeCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A0424A4FCAB006EB6D5 /* VergeCore.framework */; };
4B19FCCA252E33D5003A628D /* VergeCore.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A0424A4FCAB006EB6D5 /* VergeCore.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
4B19FCCB252E33D5003A628D /* VergeStore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A0824A4FCAB006EB6D5 /* VergeStore.framework */; };
4B19FCCC252E33D5003A628D /* VergeStore.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A0824A4FCAB006EB6D5 /* VergeStore.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
4B7149E724A4FC90006EB6D5 /* Demo.h in Headers */ = {isa = PBXBuildFile; fileRef = 4B7149E524A4FC90006EB6D5 /* Demo.h */; settings = {ATTRIBUTES = (Public, ); }; };
4B714A9524A4FD51006EB6D5 /* SpotifyUIKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A8E24A4FD51006EB6D5 /* SpotifyUIKit.framework */; };
4B714A9624A4FD51006EB6D5 /* SpotifyUIKit.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 4B714A8E24A4FD51006EB6D5 /* SpotifyUIKit.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
Expand Down Expand Up @@ -238,6 +246,18 @@
/* End PBXContainerItemProxy section */

/* Begin PBXCopyFilesBuildPhase section */
4B19FCCD252E33D5003A628D /* Embed Frameworks */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
dstPath = "";
dstSubfolderSpec = 10;
files = (
4B19FCCC252E33D5003A628D /* VergeStore.framework in Embed Frameworks */,
4B19FCCA252E33D5003A628D /* VergeCore.framework in Embed Frameworks */,
);
name = "Embed Frameworks";
runOnlyForDeploymentPostprocessing = 0;
};
4B714A9A24A4FD51006EB6D5 /* Embed Frameworks */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -301,6 +321,12 @@
183B8CD63E3A820A537C2EC1 /* Pods-Demo-VergeStoreDemoSwiftUI.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Demo-VergeStoreDemoSwiftUI.release.xcconfig"; path = "Target Support Files/Pods-Demo-VergeStoreDemoSwiftUI/Pods-Demo-VergeStoreDemoSwiftUI.release.xcconfig"; sourceTree = "<group>"; };
1FD3E331DC830854E203EE9C /* Pods_SpotifyService_SpotifyDemo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SpotifyService_SpotifyDemo.framework; sourceTree = BUILT_PRODUCTS_DIR; };
3114F85E3DB9175EF2B569F8 /* Pods_SpotifyService.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SpotifyService.framework; sourceTree = BUILT_PRODUCTS_DIR; };
4B19FCAA252E33A0003A628D /* StateReaderDemo.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = StateReaderDemo.app; sourceTree = BUILT_PRODUCTS_DIR; };
4B19FCAC252E33A0003A628D /* StateReaderDemoApp.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StateReaderDemoApp.swift; sourceTree = "<group>"; };
4B19FCAE252E33A0003A628D /* ContentView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ContentView.swift; sourceTree = "<group>"; };
4B19FCB0252E33A1003A628D /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
4B19FCB3252E33A1003A628D /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
4B19FCB5252E33A1003A628D /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
4B7149E224A4FC90006EB6D5 /* Demo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Demo.framework; sourceTree = BUILT_PRODUCTS_DIR; };
4B7149E524A4FC90006EB6D5 /* Demo.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = Demo.h; sourceTree = "<group>"; };
4B7149E624A4FC90006EB6D5 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
Expand Down Expand Up @@ -409,6 +435,15 @@
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
4B19FCA7252E33A0003A628D /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
4B19FCCB252E33D5003A628D /* VergeStore.framework in Frameworks */,
4B19FCC9252E33D5003A628D /* VergeCore.framework in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
4B7149DF24A4FC90006EB6D5 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -490,6 +525,26 @@
/* End PBXFrameworksBuildPhase section */

/* Begin PBXGroup section */
4B19FCAB252E33A0003A628D /* StateReaderDemo */ = {
isa = PBXGroup;
children = (
4B19FCAC252E33A0003A628D /* StateReaderDemoApp.swift */,
4B19FCAE252E33A0003A628D /* ContentView.swift */,
4B19FCB0252E33A1003A628D /* Assets.xcassets */,
4B19FCB5252E33A1003A628D /* Info.plist */,
4B19FCB2252E33A1003A628D /* Preview Content */,
);
path = StateReaderDemo;
sourceTree = "<group>";
};
4B19FCB2252E33A1003A628D /* Preview Content */ = {
isa = PBXGroup;
children = (
4B19FCB3252E33A1003A628D /* Preview Assets.xcassets */,
);
path = "Preview Content";
sourceTree = "<group>";
};
4B7149D824A4FC90006EB6D5 = {
isa = PBXGroup;
children = (
Expand All @@ -501,6 +556,7 @@
4B714A7624A4FD2C006EB6D5 /* VergeStoreDemoUIKit */,
4B714A8F24A4FD51006EB6D5 /* SpotifyUIKit */,
4B714AA124A4FD61006EB6D5 /* SpotifyService */,
4B19FCAB252E33A0003A628D /* StateReaderDemo */,
4B7149E324A4FC90006EB6D5 /* Products */,
AD6DE38C48444B06D801C3C3 /* Pods */,
D8C547534028A8A2BD8F9069 /* Frameworks */,
Expand All @@ -517,6 +573,7 @@
4B714A7524A4FD2C006EB6D5 /* VergeStoreDemoUIKit.app */,
4B714A8E24A4FD51006EB6D5 /* SpotifyUIKit.framework */,
4B714AA024A4FD61006EB6D5 /* SpotifyService.framework */,
4B19FCAA252E33A0003A628D /* StateReaderDemo.app */,
);
name = Products;
sourceTree = "<group>";
Expand Down Expand Up @@ -829,6 +886,24 @@
/* End PBXHeadersBuildPhase section */

/* Begin PBXNativeTarget section */
4B19FCA9252E33A0003A628D /* StateReaderDemo */ = {
isa = PBXNativeTarget;
buildConfigurationList = 4B19FCC4252E33A1003A628D /* Build configuration list for PBXNativeTarget "StateReaderDemo" */;
buildPhases = (
4B19FCA6252E33A0003A628D /* Sources */,
4B19FCA7252E33A0003A628D /* Frameworks */,
4B19FCA8252E33A0003A628D /* Resources */,
4B19FCCD252E33D5003A628D /* Embed Frameworks */,
);
buildRules = (
);
dependencies = (
);
name = StateReaderDemo;
productName = StateReaderDemo;
productReference = 4B19FCAA252E33A0003A628D /* StateReaderDemo.app */;
productType = "com.apple.product-type.application";
};
4B7149E124A4FC90006EB6D5 /* Demo */ = {
isa = PBXNativeTarget;
buildConfigurationList = 4B7149EA24A4FC90006EB6D5 /* Build configuration list for PBXNativeTarget "Demo" */;
Expand Down Expand Up @@ -980,10 +1055,13 @@
4B7149D924A4FC90006EB6D5 /* Project object */ = {
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 1150;
LastSwiftUpdateCheck = 1200;
LastUpgradeCheck = 1150;
ORGANIZATIONNAME = muukii;
TargetAttributes = {
4B19FCA9252E33A0003A628D = {
CreatedOnToolsVersion = 12.0;
};
4B7149E124A4FC90006EB6D5 = {
CreatedOnToolsVersion = 11.5;
};
Expand Down Expand Up @@ -1043,6 +1121,7 @@
4B714A7424A4FD2C006EB6D5 /* VergeStoreDemoUIKit */,
4B714A8D24A4FD51006EB6D5 /* SpotifyUIKit */,
4B714A9F24A4FD61006EB6D5 /* SpotifyService */,
4B19FCA9252E33A0003A628D /* StateReaderDemo */,
);
};
/* End PBXProject section */
Expand Down Expand Up @@ -1135,6 +1214,15 @@
/* End PBXReferenceProxy section */

/* Begin PBXResourcesBuildPhase section */
4B19FCA8252E33A0003A628D /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
4B19FCB4252E33A1003A628D /* Preview Assets.xcassets in Resources */,
4B19FCB1252E33A1003A628D /* Assets.xcassets in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
4B7149E024A4FC90006EB6D5 /* Resources */ = {
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -1341,6 +1429,15 @@
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
4B19FCA6252E33A0003A628D /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
4B19FCAF252E33A0003A628D /* ContentView.swift in Sources */,
4B19FCAD252E33A0003A628D /* StateReaderDemoApp.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
4B7149DE24A4FC90006EB6D5 /* Sources */ = {
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -1523,6 +1620,50 @@
/* End PBXVariantGroup section */

/* Begin XCBuildConfiguration section */
4B19FCB6252E33A1003A628D /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"StateReaderDemo/Preview Content\"";
ENABLE_PREVIEWS = YES;
INFOPLIST_FILE = StateReaderDemo/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
);
PRODUCT_BUNDLE_IDENTIFIER = org.VergeGroup.StateReaderDemo;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
name = Debug;
};
4B19FCB7252E33A1003A628D /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_ASSET_PATHS = "\"StateReaderDemo/Preview Content\"";
ENABLE_PREVIEWS = YES;
INFOPLIST_FILE = StateReaderDemo/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
);
PRODUCT_BUNDLE_IDENTIFIER = org.VergeGroup.StateReaderDemo;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
};
name = Release;
};
4B7149E824A4FC90006EB6D5 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
Expand Down Expand Up @@ -1966,6 +2107,15 @@
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
4B19FCC4252E33A1003A628D /* Build configuration list for PBXNativeTarget "StateReaderDemo" */ = {
isa = XCConfigurationList;
buildConfigurations = (
4B19FCB6252E33A1003A628D /* Debug */,
4B19FCB7252E33A1003A628D /* Release */,
);
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
4B7149DC24A4FC90006EB6D5 /* Build configuration list for PBXProject "Demo" */ = {
isa = XCConfigurationList;
buildConfigurations = (
Expand Down
2 changes: 1 addition & 1 deletion Demo/Demo.xcodeproj/project.xcworkspace/contents.xcworkspacedata
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Demo/Podfile.lock
View file
Open in desktop
Expand Up @@ -43,4 +43,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: a3c956eee2afed4aad880f4a1c754774ef88d76f

COCOAPODS: 1.9.1
COCOAPODS: 1.9.3
11 changes: 11 additions & 0 deletions Demo/StateReaderDemo/Assets.xcassets/AccentColor.colorset/Contents.json
View file
Open in desktop
@@ -0,0 +1,11 @@
{
"colors" : [
{
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
98 changes: 98 additions & 0 deletions Demo/StateReaderDemo/Assets.xcassets/AppIcon.appiconset/Contents.json
View file
Open in desktop
@@ -0,0 +1,98 @@
{
"images" : [
{
"idiom" : "iphone",
"scale" : "2x",
"size" : "20x20"
},
{
"idiom" : "iphone",
"scale" : "3x",
"size" : "20x20"
},
{
"idiom" : "iphone",
"scale" : "2x",
"size" : "29x29"
},
{
"idiom" : "iphone",
"scale" : "3x",
"size" : "29x29"
},
{
"idiom" : "iphone",
"scale" : "2x",
"size" : "40x40"
},
{
"idiom" : "iphone",
"scale" : "3x",
"size" : "40x40"
},
{
"idiom" : "iphone",
"scale" : "2x",
"size" : "60x60"
},
{
"idiom" : "iphone",
"scale" : "3x",
"size" : "60x60"
},
{
"idiom" : "ipad",
"scale" : "1x",
"size" : "20x20"
},
{
"idiom" : "ipad",
"scale" : "2x",
"size" : "20x20"
},
{
"idiom" : "ipad",
"scale" : "1x",
"size" : "29x29"
},
{
"idiom" : "ipad",
"scale" : "2x",
"size" : "29x29"
},
{
"idiom" : "ipad",
"scale" : "1x",
"size" : "40x40"
},
{
"idiom" : "ipad",
"scale" : "2x",
"size" : "40x40"
},
{
"idiom" : "ipad",
"scale" : "1x",
"size" : "76x76"
},
{
"idiom" : "ipad",
"scale" : "2x",
"size" : "76x76"
},
{
"idiom" : "ipad",
"scale" : "2x",
"size" : "83.5x83.5"
},
{
"idiom" : "ios-marketing",
"scale" : "1x",
"size" : "1024x1024"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
6 changes: 6 additions & 0 deletions Demo/StateReaderDemo/Assets.xcassets/Contents.json
View file
Open in desktop
@@ -0,0 +1,6 @@
{
"info" : {
"author" : "xcode",
"version" : 1
}
}