New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for using library as a transative dep #71

Merged

SimonCropp merged 1 commit into VerifyTests:master from slang25:fix-net5-shouldly

Nov 14, 2020

Contributor

slang25 commented Nov 14, 2020

See shouldly/shouldly#717

I've tested this locally by hacking about with my .nuget/packages folder, it seems to do the trick but could use another pair of eyes.

I've also removed buildMultiTargeting here, as I don't think we need to do an "outer build" import, we only want to operate at a per-tfm basis.


          Fix for using library as a transative dep

2f681d1

slang25 mentioned this pull request

Approval methods fail with TypeInitializationException under .NET 5 shouldly/shouldly#717

Closed

Member

SimonCropp commented Nov 14, 2020

Thanks for this. i will deploy and smoke test

SimonCropp added this to the 2.3.1 milestone

SimonCropp merged commit df90548 into VerifyTests:master

SimonCropp added the Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment