Skip to content

Commit

Permalink
Write $parent value for property that is parent (#973)
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonCropp committed Aug 27, 2023
1 parent 58858f7 commit afd0da4
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;msb3277;CS0436;CS1573;NU1901;NU1902</NoWarn>
<Version>20.8.1</Version>
<Version>20.8.2</Version>
<ImplicitUsings>enable</ImplicitUsings>
<LangVersion>11</LangVersion>
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"SelfProperty": "$parentValue"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
SelfProperty: $parentValue
}
21 changes: 21 additions & 0 deletions src/Verify.Tests/Serialization/SerializationTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3319,6 +3319,27 @@ class ConverterTarget
public string Name { get; set; } = null!;
}

[Fact]
public Task WithRecursiveConverter() =>
Verify(new RecursiveConverterTarget())
.AddExtraSettings(_ => _.Converters.Add(new RecursiveConverter()));

class RecursiveConverter :
WriteOnlyJsonConverter<RecursiveConverterTarget>
{
public override void Write(VerifyJsonWriter writer, RecursiveConverterTarget target)
{
writer.WriteStartObject();
writer.WriteMember(target, target.Self, "SelfProperty");
writer.WriteEnd();
}
}

class RecursiveConverterTarget
{
public RecursiveConverterTarget Self => this;
}

[ModuleInitializer]
public static void WithConverterAndMemberConverterInit() =>
VerifierSettings.MemberConverter<StaticConverterTarget, string>(
Expand Down
7 changes: 7 additions & 0 deletions src/Verify/Serialization/VerifyJsonWriter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ public void WriteMember(object target, object? value, string name)
return;
}

if (ReferenceEquals(target, value))
{
WritePropertyName(name);
WriteRawValueIfNoStrict("$parentValue");
return;
}

var declaringType = target.GetType();
var memberType = value.GetType();
if (serialization.TryGetScrubOrIgnore(declaringType, memberType, name, out var scrubOrIgnore))
Expand Down

0 comments on commit afd0da4

Please sign in to comment.