fix bug in VerifyXml (#938)

VerifyTests · Jul 16, 2023 · f86da5d · f86da5d
1 parent e756bc8
commit f86da5d
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 3 deletions.
diff --git a/src/Verify.Tests/XmlTests.EmptyTag.verified.xml b/src/Verify.Tests/XmlTests.EmptyTag.verified.xml
@@ -0,0 +1,4 @@
+<body>
+  <empty />
+  <node>text</node>
+</body>
diff --git a/src/Verify.Tests/XmlTests.EmptyTagWithAttributes.verified.xml b/src/Verify.Tests/XmlTests.EmptyTagWithAttributes.verified.xml
@@ -0,0 +1,4 @@
+<body>
+  <empty id="Guid_1" att="asdf" />
+  <node>text</node>
+</body>
diff --git a/src/Verify.Tests/XmlTests.IgnoreAttribute.verified.xml b/src/Verify.Tests/XmlTests.IgnoreAttribute.verified.xml
@@ -1,3 +1,3 @@
 <body>
-  <node att="Scrubbed"></node>
+  <node att="Scrubbed" />
 </body>
diff --git a/src/Verify.Tests/XmlTests.ScrubAttribute.verified.xml b/src/Verify.Tests/XmlTests.ScrubAttribute.verified.xml
@@ -1,3 +1,3 @@
 <body>
-  <node></node>
+  <node />
 </body>
diff --git a/src/Verify.Tests/XmlTests.cs b/src/Verify.Tests/XmlTests.cs
@@ -110,4 +110,12 @@ public Task IgnoreAttribute()
     public Task XDocScrubMember() =>
         Verify(XDocument.Parse(xml))
             .ScrubMember("node");
+
+    [Fact]
+    public Task EmptyTag() =>
+        VerifyXml("<body><empty /><node>text</node></body>");
+
+    [Fact]
+    public Task EmptyTagWithAttributes() =>
+        VerifyXml($@"<body><empty id=""{Guid.NewGuid()}"" att=""asdf"" /><node>text</node></body>");
 }
diff --git a/src/Verify/Verifier/InnerVerifier_Xml.cs b/src/Verify/Verifier/InnerVerifier_Xml.cs
@@ -96,7 +96,7 @@ async Task<VerifyResult> VerifyXml(XContainer? target)
                 attribute.Value = ConvertValue(serialization, attribute.Value);
             }
 
-            if (node.HasElements)
+            if (node.IsEmpty || node.HasElements)
             {
                 continue;
             }