Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 1.5.2 breaks compatibility with .NET 2.0 Standard #110

Closed
ktyldev opened this issue Jul 26, 2023 · 1 comment · Fixed by #111
Closed

[BUG] 1.5.2 breaks compatibility with .NET 2.0 Standard #110

ktyldev opened this issue Jul 26, 2023 · 1 comment · Fixed by #111
Labels
bug Something isn't working

Comments

@ktyldev
Copy link

ktyldev commented Jul 26, 2023

Describe the bug

Version 1.5.2 breaks compatibility with .NET 2.0 Standard projects due to the inclusion of a C# 8.0 feature. This should be at least a MINOR version upgrade as per semver.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Unity project using 2020.3.38f1
  2. Import ParrelSync 1.5.1
  3. Confirm no compilation errors
  4. Remove 1.5.1, import 1.5.2
  5. Compilation error on Editor/Preferences.cs:91 due to the use of a nullable reference type.

Expected behavior

No compilation errors.

Screenshots/Video
If applicable, add screenshots or video link( Youtube/Vimeo) to help explain the problem.

image

Enviroment (please complete the following information):

  • Unity Editor Version: 2020.3.38f1
  • ParrelSync Version: 1.5.2
  • OS Version: Windows 11 22H2

Additional context
Add any other context about the problem here.
@ktyldev ktyldev added the bug Something isn't working label Jul 26, 2023
@ktyldev ktyldev changed the title [BUG] [BUG] 1.5.2 breaks compatibility with .NET 2.0 Standard Jul 26, 2023
ktyldev added a commit to ktyldev/ParrelSync that referenced this issue Jul 26, 2023
@ktyldev
fix: use .NET 2.0 compatible overload (VeriorPies#110)
6d8b651 
Change the .ToSplit() overload to one which is compatible with .NET 2.0,
instead of one using a nullable string parameter.
@ktyldev ktyldev mentioned this issue Jul 26, 2023
Merged
314pies pushed a commit that referenced this issue May 15, 2024
@ktyldev @314pies
fix: use .NET 2.0 compatible overload (#110)
f446ee9 
Change the .ToSplit() overload to one which is compatible with .NET 2.0,
instead of one using a nullable string parameter.
@314pies
Copy link
Contributor

314pies commented May 25, 2024

duplicate #116

@314pies 314pies closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use .NET 2.0 compatible overload (#110) ktyldev/ParrelSync
2 participants
@ktyldev @314pies