Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187 - Refactor ProteinFinder #199

Closed
wants to merge 0 commits into from

Conversation

boaglio
Copy link
Contributor

@boaglio boaglio commented Oct 13, 2022

  • removed properties and change to static class (ProteinFinder look like an Util class, not a Domain class)
  • extracted one internal loop to a private method
  • created some constants
  • changes some variable names to camel case standard

Test

Successful test using parameters:

--amino=histidine --max=5 --min=3 assets/dna/random/dnalong.fa

Closes #187

@VerisimilitudeX
Copy link
Owner

Hey @boaglio, I will be out of office for some time, so it will take me some time merge the pull request. However, I will approve the pull request in case you are participating in Hacktoberfest. Thanks for working on this, we at DNAnalyzer really appreciate your help!

@VerisimilitudeX
Copy link
Owner

@boaglio could you please star this repository of you haven’t already.

@boaglio
Copy link
Contributor Author

boaglio commented Oct 17, 2022

I did star already =)

@VerisimilitudeX
Copy link
Owner

I did star already =)

Thanks!

@VerisimilitudeX
Copy link
Owner

@boaglio could you please clear the merge conflicts! I'll approve your PR once you do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ProteinFinder.getProtein(String,String)
2 participants