This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Ensure codecs defined by user are byte aligned without the user havin… #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to worry about it (for instance, if a user defines an optional member of a larger structure with optional(bool, optionalCodec), since bool is by default 1 bit, the codec using it will result in weird runtime error because the codec itself is not byte aligned - by wrapping in byteAligned combinator within Remotely, it will be transparently byte aligned)
timperrett
added a commit
that referenced
this pull request
Jan 6, 2016
Ensure codecs defined by user are byte aligned without the user havin…
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g to worry about it (for instance, if a user defines an optional member of a larger structure with optional(bool, optionalCodec), since bool is by default 1 bit, the codec using it will result in weird runtime error because the codec itself is not byte aligned - by wrapping in byteAligned combinator within Remotely, it will be transparently byte aligned)