ok Travis, smartass #98
Conversation
- make ssl handshake remove negotation from handler pipe. - make tests in `ServerErrors` report more details when things fail.
| sh.handshakeFuture().addListener(new GenericFutureListener[Future[Channel]] { | ||
| def operationComplete(future: Future[Channel]): Unit = { | ||
| // avoid negotiation when ssl fails | ||
| if(!future.isSuccess) { pipe.remove(negotiateCapable) } |
There was a problem hiding this comment.
This is brittle and a bit like playing whack-a-mole. There has to be a more robust way to short-circuit.
|
|
|
@ahjohannessen is this good to merge? travis passed it, but the comments suggest you're not entirely happy? |
|
@timperrett I would like to test it a bit better. Lately, I've been very busy with work and also been on vacation, but soon I'll put my focus on this again. I've seen some null pointer exceptions when putting client<->server under load and wish to identify root causes and fix that. |
|
Furthermore, it would be interesting to migrate to fs2 in a branch as soon it is ready for the real world :) |
|
Sure, sounds good on both counts :-) |
|
Time to focus on this again, hopefully #109 can get in first. |
Just me investigating why Travis is failing like a champ.