Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

VVPSDK.version getter #25

Merged
merged 1 commit into from
Jan 11, 2019
Merged

VVPSDK.version getter #25

merged 1 commit into from
Jan 11, 2019

Conversation

AndriiMoskvin
Copy link
Contributor

  • Release of version 1.1.0
  • VVPSDK.version getter added

@AndriiMoskvin AndriiMoskvin self-assigned this Jan 10, 2019
@balavor
Copy link
Contributor

balavor commented Jan 10, 2019

screen shot 2019-01-10 at 15 22 15

Not so pretty as for me. I prefer how it used to be before.

@vvp-sdk-bot
Copy link

vvp-sdk-bot commented Jan 10, 2019 •
edited
Loading

Current coverage for PlayerCore.framework is 53.67%

✅ No files affecting coverage found

Current coverage for VerizonVideoPartnerSDK.framework is 36.12%

Files changed - -
VVPSDK_Version.swift 0.00% 💀

Powered by xcov

Generated by 🚫 Danger

@AndriiMoskvin
Copy link
Contributor Author

AndriiMoskvin commented Jan 10, 2019 •
edited
Loading

@RomanTysiachnik I will try correct this.

@AndriiMoskvin
Copy link
Contributor Author

@RomanTysiachnik RFR.

@AndriiMoskvin AndriiMoskvin force-pushed the OMSDK-2118/public-version-getter branch from c680c14 to fd73267 Compare January 10, 2019 14:55
@AndriiMoskvin AndriiMoskvin force-pushed the OMSDK-2118/public-version-getter branch from fd73267 to 091cdd5 Compare January 10, 2019 16:03
@AndriiMoskvin
Copy link
Contributor Author

@RomanTysiachnik RFR.

balavor
balavor approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@balavor balavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@AndriiMoskvin AndriiMoskvin merged commit a629cc2 into master Jan 11, 2019
@AndriiMoskvin AndriiMoskvin deleted the OMSDK-2118/public-version-getter branch January 11, 2019 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balavor balavor balavor approved these changes

Assignees

@AndriiMoskvin AndriiMoskvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiMoskvin @balavor @vvp-sdk-bot