Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Repo links update + release 1.2.0 #26

Merged
merged 4 commits into from
Jan 14, 2019
Merged

Repo links update + release 1.2.0 #26

merged 4 commits into from
Jan 14, 2019

Conversation

AndriiMoskvin
Copy link
Contributor

@AndriiMoskvin AndriiMoskvin commented Jan 11, 2019 •
edited
Loading

  • Build scripts update - automatic pod spec lint on Travis
  • Update of dependencies
  • Renaming from OathVideoPartnerSDK -> VerizonVideoPartnerSDK

@AndriiMoskvin AndriiMoskvin self-assigned this Jan 11, 2019
@vvp-sdk-bot
Copy link

vvp-sdk-bot commented Jan 11, 2019 •
edited
Loading

2 Warnings
⚠️ This PR does not have any reviewers yet.
⚠️ Big PR - break it to smaller PRs.

Current coverage for PlayerCore.framework is 53.67%

✅ No files affecting coverage found

Current coverage for VerizonVideoPartnerSDK.framework is 36.12%

Files changed - -
VVPSDK_Version.swift 0.00% 💀
JavaScriptObserver.swift 0.00% 💀
AdURLProvider.swift 88.60% ✅
Observer.swift 95.24% ✅

Powered by xcov

Generated by 🚫 Danger

@AndriiMoskvin AndriiMoskvin force-pushed the OMSDK-2021/links-update branch 4 times, most recently from 81aca95 to f765909 Compare January 14, 2019 13:06
@AndriiMoskvin AndriiMoskvin changed the title WIP: repo links update + release 1.2.0 Repo links update + release 1.2.0 Jan 14, 2019
@AndriiMoskvin
Copy link
Contributor Author

@VladyslavAnokhin @RomanTysiachnik RFR.

balavor
balavor reviewed Jan 14, 2019
View reviewed changes
fastlane/Fastfile
@@ -67,7 +67,7 @@ end

lane :is_latest_video_renderer do |_options|
result = false
Dir.chdir('../Carthage/Checkouts/OneMobileSDK-videorenderer-ios') do
Dir.chdir('../Carthage/Checkouts/VerizonVideoPartnerSDK-videorenderer-ios') do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who knows - these scripts are no longer used and it is highly possible we will drop them.

@AndriiMoskvin AndriiMoskvin merged commit 1fe6196 into master Jan 14, 2019
@AndriiMoskvin AndriiMoskvin deleted the OMSDK-2021/links-update branch January 14, 2019 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balavor balavor balavor approved these changes

@VladyslavAnokhin VladyslavAnokhin VladyslavAnokhin approved these changes

Assignees

@AndriiMoskvin AndriiMoskvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndriiMoskvin @vvp-sdk-bot @VladyslavAnokhin @balavor