This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Updated PlaybackCycle detector to correctly fire complete trackers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
from
f7bd332
to
9bd1406
Compare
AndriiMoskvin
previously requested changes
Jan 18, 2019
sources/metrics/tracking pixels/TrackingPixelsConnector_Ad.swift
Outdated
Show resolved
Hide resolved
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
from
9bd1406
to
1041a85
Compare
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
from
1041a85
to
98b8e48
Compare
sources/metrics/detectors/playback cycle/ContentPlaybackCycleDetectorTests.swift
Outdated
Show resolved
Hide resolved
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
2 times, most recently
from
e19c288
to
bf6833e
Compare
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| TrackingPixelsConnector.swift | 0.00% |
💀 |
| Player_VideoEvents.swift | 0.00% |
💀 |
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| PlayerProperties_Init.swift | 89.30% |
✅ |
| AdPlaybackCycleDetector.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
from
bf6833e
to
a2ef219
Compare
balavor
force-pushed
the
OMSDK-2148/ad-complete
branch
from
a2ef219
to
5955d3b
Compare
| var isStartRecorded = false | ||
|
|
||
| func process(streamPlaying: Bool, isSuccessfullyCompleted: Bool, isForceFinished: Bool) -> Result { | ||
| guard isForceFinished == false else { |
VladyslavAnokhin
approved these changes
Jan 22, 2019
AndriiMoskvin
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated
adPlaybackCycledetector to reset the state but not fire the complete tracker when the ad is finished.Tests
@VerizonAdPlatforms/mobile-sdk-developers: Please review.