This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Added vpaid controller and updated PlayerCore #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/advertisements/creative controllers/MP4AdCreativeControllerTest.swift
Show resolved
Hide resolved
sources/advertisements/creative controllers/VPAIDAdCreativeController.swift
Outdated
Show resolved
Hide resolved
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| PlayerViewController.swift | 0.00% |
💀 |
| PlayerViewController_Binding.swift | 0.00% |
💀 |
| PlayerViewController_Clickthrough.swift | 0.00% |
💀 |
| PropsMapping.swift | 0.00% |
💀 |
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| VVPSDK.swift | 0.00% |
💀 |
| PlayerProperties.swift | 25.00% |
🚫 |
| VPAIDAdCreativeController.swift | 50.00% |
|
| MP4AdCreativeController.swift | 57.14% |
|
| PlayerProperties_Init.swift | 89.32% |
✅ |
Powered by xcov
Generated by 🚫 Danger
balavor
force-pushed
the
OMSDK-2199/ad-component-refactoring
branch
from
bb1eec8
to
334a8d6
Compare
| guard case .mp4(let creatives) = adCreative, | ||
| processedCreatives.contains(adCreative) == false, | ||
| let dimensions = viewport, | ||
| let id = id else { return } |
AndriiMoskvin
approved these changes
Feb 1, 2019
VladyslavAnokhin
approved these changes
Feb 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
VPAIDAdCreativeControllerto play vpaid ads. In further, this will be the place, where failover logic will be implemented.FinalResultDispatchControlleris now fully dropped and replaced with those two controllers for mp4 and vpaid.PlayerCoreand updated our code due to the changes in Core.@VerizonAdPlatforms/video-partner-sdk-developers: Please review.