This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Added vpaid controller and updated PlayerCore #51
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule PlayerCore
updated
from 7f1202 to 96fda6
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
sources/advertisements/VRM New Core/Controllers/FinalResultDispatchController.swift
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
sources/advertisements/creative controllers/AdCreativeTestData.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Copyright 2019, Oath Inc. | ||
| // Licensed under the terms of the MIT License. See LICENSE.md file in project root for terms. | ||
|
|
||
| import Foundation | ||
| import PlayerCore | ||
|
|
||
| func getMP4Creative(width: Int, height: Int) -> AdCreative.MP4 { | ||
| let testURL = URL(string: "https://")! | ||
| return AdCreative.MP4(url: testURL, | ||
| clickthrough: testURL, | ||
| pixels: AdPixels(), | ||
| id: "", | ||
| width: width, | ||
| height: height, | ||
| scalable: false, | ||
| maintainAspectRatio: true) | ||
| } | ||
|
|
||
| func getVPAIDCreative() -> AdCreative.VPAID { | ||
| let testURL = URL(string: "https://")! | ||
| return AdCreative.VPAID(url: testURL, | ||
| adParameters: "", | ||
| clickthrough: testURL, | ||
| pixels: AdPixels(), | ||
| id: "") | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
sources/advertisements/creative controllers/VPAIDAdCreativeController.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2019, Oath Inc. | ||
| // Licensed under the terms of the MIT License. See LICENSE.md file in project root for terms. | ||
|
|
||
| import Foundation | ||
| import PlayerCore | ||
|
|
||
| final class VPAIDAdCreativeController { | ||
| let dispatch: (PlayerCore.Action) -> Void | ||
| private var processedCreatives = Set<PlayerCore.AdCreative>() | ||
|
|
||
| init(dispatch: @escaping (PlayerCore.Action) -> Void) { | ||
| self.dispatch = dispatch | ||
| } | ||
|
|
||
|
|
||
| func process(state: State) { | ||
| process(adCreative: state.selectedAdCreative, id: state.vrmRequestStatus.request?.id) | ||
| } | ||
|
|
||
| func process(adCreative: PlayerCore.AdCreative, id: UUID?) { | ||
| guard case .vpaid(let creatives) = adCreative, | ||
| processedCreatives.contains(adCreative) == false, | ||
| let creative = creatives.first, | ||
| let id = id else { return } | ||
|
|
||
| processedCreatives.insert(adCreative) | ||
| dispatch(PlayerCore.showVPAIDAd(creative: creative, id: id)) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉