Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Added Start group processing controller #6

Merged

Conversation

VladyslavAnokhin
Copy link
Contributor

Changes

Dispatch next group if current one equal to nil and next group exists

JIRA Ticket

@OathAdPlatforms/mobile-sdk-developers: Please review.

@vvp-sdk-bot
Copy link

vvp-sdk-bot commented Dec 17, 2018

Current coverage for OathVideoPartnerSDK.framework is 35.89%

Files changed - -
OVPSDK.swift 0.00% 💀
StartVRMGroupProcessingController.swift 42.86% 🚫

Current coverage for PlayerCore.framework is 53.79%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@VladyslavAnokhin VladyslavAnokhin force-pushed the OMSDK-2020/create-group-processing-controller branch from 509bda2 to 84c10eb Compare December 17, 2018 14:27
let vrmRequestController = VRMRequestController(dispatch: dispatcher,
groupsMapper: mapGroups) { url -> Future<VRMProvider.Response?> in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


final class StartVRMGroupProcessingController {

let dispatch: (PlayerCore.Action)->()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(PlayerCore.Action) -> () - looks like your space keyboard button is not working :(

@VladyslavAnokhin VladyslavAnokhin force-pushed the OMSDK-2020/create-group-processing-controller branch from 84c10eb to 150440d Compare December 17, 2018 15:57
@VladyslavAnokhin VladyslavAnokhin merged commit 9b28d55 into master Dec 17, 2018
@VladyslavAnokhin VladyslavAnokhin deleted the OMSDK-2020/create-group-processing-controller branch December 17, 2018 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants