This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Added Start group processing controller #6
Merged
VladyslavAnokhin
merged 1 commit into
master
from
OMSDK-2020/create-group-processing-controller
Dec 17, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule PlayerCore
updated
from 14c2ab to 1a8e25
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
sources/advertisements/VRM New Core/Controllers/StartVRMGroupProcessingController.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright 2018, Oath Inc. | ||
| // Licensed under the terms of the MIT License. See LICENSE.md file in project root for terms. | ||
|
|
||
| import Foundation | ||
| import PlayerCore | ||
|
|
||
| final class StartVRMGroupProcessingController { | ||
|
|
||
| let dispatch: (PlayerCore.Action) -> () | ||
|
|
||
| init(dispatch: @escaping (PlayerCore.Action) -> ()) { | ||
| self.dispatch = dispatch | ||
| } | ||
|
|
||
| func process(with state: PlayerCore.State) { | ||
| process(with: state.vrmCurrentGroup.currentGroup, | ||
| groupsQueue: state.vrmGroupsQueue.groupsQueue) | ||
| } | ||
|
|
||
| func process(with currentGroup: VRMCore.Group?, | ||
| groupsQueue: [VRMCore.Group]) { | ||
| guard currentGroup == nil, | ||
| let nextGroup = groupsQueue.first else { return } | ||
|
|
||
| dispatch(VRMCore.startGroupProcessing(group: nextGroup)) | ||
|
|
||
| } | ||
| } |
75 changes: 75 additions & 0 deletions
75
sources/advertisements/VRM New Core/Controllers/StartVRMGroupProcessingControllerTest.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| // Copyright 2018, Oath Inc. | ||
| // Licensed under the terms of the MIT License. See LICENSE.md file in project root for terms. | ||
|
|
||
| import XCTest | ||
| @testable import OathVideoPartnerSDK | ||
| @testable import PlayerCore | ||
|
|
||
| class StartVRMGroupProcessingControllerTest: XCTestCase { | ||
|
|
||
| let recorder = Recorder() | ||
| let firstGroup = VRMCore.Group(items: []) | ||
| let secondGroup = VRMCore.Group(items: []) | ||
|
|
||
| var sut: StartVRMGroupProcessingController! | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
| let dispatch = recorder.hook("testDispatchFirstGroup") { target, recorded in | ||
| guard let target = target as? PlayerCore.VRMCore.StartGroupProcessing, | ||
| let recorded = recorded as? PlayerCore.VRMCore.StartGroupProcessing else { | ||
| return false | ||
| } | ||
| return target.group == recorded.group | ||
|
|
||
| } as (PlayerCore.Action) -> () | ||
|
|
||
| sut = StartVRMGroupProcessingController(dispatch: dispatch) | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| recorder.verify {} | ||
| recorder.clean() | ||
| super.tearDown() | ||
| } | ||
|
|
||
| func testDispatchFirstGroup() { | ||
| recorder.record { | ||
| sut.process(with: nil, | ||
| groupsQueue: [firstGroup, secondGroup]) | ||
| } | ||
|
|
||
| recorder.verify { | ||
| sut.dispatch(VRMCore.startGroupProcessing(group: firstGroup)) | ||
| } | ||
| } | ||
|
|
||
| func testStartLastGroup() { | ||
| recorder.record { | ||
| sut.process(with: nil, | ||
| groupsQueue: [secondGroup]) | ||
| } | ||
|
|
||
| recorder.verify { | ||
| sut.dispatch(VRMCore.startGroupProcessing(group: secondGroup)) | ||
| } | ||
| } | ||
|
|
||
| func testNonEmptyCurrentGroup() { | ||
| recorder.record { | ||
| sut.process(with: firstGroup, | ||
| groupsQueue: [secondGroup]) | ||
| } | ||
|
|
||
| recorder.verify {} | ||
| } | ||
|
|
||
| func testEmptyCurrentGroupAndQueue() { | ||
| recorder.record { | ||
| sut.process(with: nil, | ||
| groupsQueue: []) | ||
| } | ||
|
|
||
| recorder.verify {} | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍