This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Added reporting empty ad or vpaid if it's not allowed #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladyslavAnokhin
force-pushed
the
OMSDK-2238/fix-for-vpaid
branch
from
6fedac7
to
25991a1
Compare
AndriiMoskvin
previously approved these changes
Feb 11, 2019
VladyslavAnokhin
force-pushed
the
OMSDK-2238/fix-for-vpaid
branch
from
25991a1
to
a105178
Compare
VladyslavAnokhin
force-pushed
the
OMSDK-2238/fix-for-vpaid
branch
from
a105178
to
a8e6a05
Compare
balavor
reviewed
Feb 12, 2019
| } else if case .wrapper(let wrapper) = result.vastModel { | ||
| switch result.vastModel { | ||
| case .inline(let vast): | ||
| let isModelContainAd = (isVPAIDAllowed && !vast.vpaidMediaFiles.isEmpty) || !vast.mp4MediaFiles.isEmpty |
balavor
approved these changes
Feb 12, 2019
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| FinishVRMGroupProcessingController.swift | 38.46% |
🚫 |
| AdEngineResponseDetector.swift | 78.57% |
|
| VRMProcessingController.swift | 80.49% |
✅ |
Powered by xcov
Generated by 🚫 Danger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Report ad which doesn't contain media files or contains not allowed VPAID
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.