Add support for SPI. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruton
approved these changes
May 27, 2020
|
Thanks for adding this! |
|
I am going to test i2c before merging. |
|
What's the status of this PR? |
|
I can verify that this works for both i2c and spi with the bluepill dev board. Looking forward to seeing this merged as this is a great little lib but i would rather use it with spi for my application. |
|
I have also verified this works on SPI, could we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patches add support for BME280s connected via SPI. They move the i2c-specific parts of the driver to crate::i2c:: and add a second "BME280" struct in crate::spi::.
What is still missing is an example about how to use the sensor - where should that example go?
I was not able to test I2C functionality after the changes, but SPI seems to work.