fix: enable cgo on macos builds #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapkon
approved these changes
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
+ Coverage 40.44% 41.96% +1.52%
==========================================
Files 54 54
Lines 8276 6381 -1895
==========================================
- Hits 3347 2678 -669
+ Misses 4491 3266 -1225
+ Partials 438 437 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mapkon is it possible to re-release macos releases ? |
|
Sure, I will attempt that tomorrow.
Mark
…On Fri, 29 Mar 2024 at 19:25, Jean-Yves CAMIER ***@***.***> wrote:
@mapkon <https://github.com/mapkon> is it possible to re-release macos
releases ?
—
Reply to this email directly, view it on GitHub
<#1243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQV5PGAPF7BOK2KRIQ2QTY2UQRLAVCNFSM6AAAAABFHHSVUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWHEZTQMZYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Done! |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just like it's done on https://github.com/Versent/saml2aws/blob/master/.goreleaser.ubuntu-20.04.yml#L23-L24
fixes #900 #873