Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing saved credential issue for --credential-process introduced by https://github.com/Versent/saml2aws/pull/896 #1274

Merged
merged 3 commits into from
May 21, 2024

Conversation

timharris777
Copy link
Contributor

PR to address this: #895 (comment)

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 41.89%. Comparing base (16a69e6) to head (1af5aca).
Report is 16 commits behind head on master.

Files Patch % Lines
cmd/saml2aws/commands/login.go 40.00% 8 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   41.93%   41.89%   -0.04%     
==========================================
  Files          54       54              
  Lines        6386     6425      +39     
==========================================
+ Hits         2678     2692      +14     
- Misses       3271     3291      +20     
- Partials      437      442       +5     
Flag Coverage Δ
unittests 41.89% <40.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon linked an issue May 21, 2024 that may be closed by this pull request
@mapkon mapkon merged commit 2951611 into Versent:master May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

credential_process - expired tokens not getting refreshed by awscli
3 participants