Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable KeyCloak password error validator #1275

Merged
merged 2 commits into from
May 21, 2024

Conversation

kenjikikuchi
Copy link
Contributor

@kenjikikuchi kenjikikuchi commented May 19, 2024

This PR is for the issue #1265. Thank you.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 42.08%. Comparing base (16a69e6) to head (5faf7c8).
Report is 16 commits behind head on master.

Files Patch % Lines
pkg/provider/keycloak/keycloak.go 63.63% 7 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   41.93%   42.08%   +0.15%     
==========================================
  Files          54       54              
  Lines        6386     6427      +41     
==========================================
+ Hits         2678     2705      +27     
- Misses       3271     3280       +9     
- Partials      437      442       +5     
Flag Coverage Δ
unittests 42.08% <63.63%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon merged commit 48be77c into Versent:master May 21, 2024
8 checks passed
@kenjikikuchi
Copy link
Contributor Author

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

@mapkon
Copy link
Member

mapkon commented May 28, 2024

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

Should be released now. It should take a bit to percolate through the binary/package distribution systems.

@mapkon
Copy link
Member

mapkon commented May 28, 2024

@mapkon, thank you for merging this PR. I am looking forward to seeing the next release!

And again, thank you for developing and maintaining this awesome software! 👍

Thanks @kenjikikuchi for the kind words, but I am not the developer - that is @wolfeidau. I am just a simple maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Keycloak] Customizable Password Error Validator
3 participants